Skip to contentSkip to conversation

patch "tty/serial: atmel: fix TX path in atmel_console_write()" added to tty-linus

PATCH [email protected] 1 participant 1 message Mar 31, 2017

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

tty/serial: atmel: fix TX path in atmel_console_write()

to my tty git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
in the tty-linus branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.

If you have any questions about this process, please let me know.

Quoted 1 line

From 497e1e16f45c70574dc9922c7f75c642c2162119 Mon Sep 17 00:00:00 2001

From: Nicolas Ferre <[email protected]>
Date: Mon, 20 Mar 2017 16:38:57 +0100
Subject: tty/serial: atmel: fix TX path in atmel_console_write()

A side effect of 89d8232411a8 ("tty/serial: atmel_serial: BUG: stop DMA from transmitting in stop_tx") is that the console can be called with TX path disabled. Then the system would hang trying to push charecters out in atmel_console_putchar().

Fixes 89d8232411a8 ("tty/serial: atmel_serial: BUG: stop DMA from transmitting

in stop_tx")

---
 drivers/tty/serial/atmel_serial.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/tty/serial/atmel_serial.c +3 -0
index 5f644515ed33..1f50a83ef958 100644
@@ -2488,6 +2488,9 @@ static void atmel_console_write(struct console *co, const char *s, u_int count)
 	pdc_tx = atmel_uart_readl(port, ATMEL_PDC_PTSR) & ATMEL_PDC_TXTEN;
 	atmel_uart_writel(port, ATMEL_PDC_PTCR, ATMEL_PDC_TXTDIS);
 
+	/* Make sure that tx path is actually able to send characters */
+	atmel_uart_writel(port, ATMEL_US_CR, ATMEL_US_TXEN);
+
 	uart_console_write(port, s, count, atmel_console_putchar);
 
 	/*
Signature · 1 line
2.12.1