Skip to contentSkip to conversation

busybox.inc: drop comment explaining '-e MAKEFLAGS=' in EXTRA_OEMAKE

PATCH In review Andre McCurdy 2 participants 2 messages Apr 4, 2017

lore
Share & tools
lore

Andre McCurdy

author
#0 lore raw

PATCH 1/1 busybox.inc: drop comment explaining '-e MAKEFLAGS=' in EXTRA_OEMAKE

EXTRA_OEMAKE no longer contains '-e MAKEFLAGS=' so the comment explaining that it needs to be removed / over-ridden is obsolete.

Signed-off-by Andre McCurdy <[email protected]>
---
 meta/recipes-core/busybox/busybox.inc | 1 -
 1 file changed, 1 deletion(-)
meta/recipes-core/busybox/busybox.inc +0 -1
index 6246c95..375632d 100644
@@ -18,7 +18,6 @@ BUSYBOX_SPLIT_SUID ?= "1"
 export EXTRA_CFLAGS = "${CFLAGS}"
 export EXTRA_LDFLAGS = "${LDFLAGS}"
 
-# We don't want '-e MAKEFLAGS=' in EXTRA_OEMAKE
 EXTRA_OEMAKE = "CC='${CC}' LD='${CCLD}' V=1 ARCH=${TARGET_ARCH} CROSS_COMPILE=${TARGET_PREFIX} SKIP_STRIP=y HOSTCC='${BUILD_CC}' HOSTCPP='${BUILD_CPP}'"
 
 PACKAGES =+ "${PN}-httpd ${PN}-udhcpd ${PN}-udhcpc ${PN}-syslog ${PN}-mdev ${PN}-hwclock"
Signature · 1 line
1.9.1
#1 lore raw
Quoted 23 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Andre McCurdy
Sent: den 4 april 2017 03:59
To: [email protected]
Subject: [OE-core] [PATCH] busybox.inc: drop comment explaining '-e MAKEFLAGS=' in EXTRA_OEMAKE

EXTRA_OEMAKE no longer contains '-e MAKEFLAGS=' so the comment explaining that it needs to be removed / over-ridden is obsolete.

Signed-off-by Andre McCurdy <[email protected]>
---
 meta/recipes-core/busybox/busybox.inc | 1 -
 1 file changed, 1 deletion(-)
meta/recipes- renamed from meta/recipes-core/busybox/busybox.inc +0 -0

core/busybox/busybox.inc
index 6246c95..375632d 100644

meta/recipes-core/busybox/busybox.inc BUSYBOX_SPLIT_SUID ?= "1" · line 21

Quoted 5 lines
meta/recipes-core/busybox/busybox.inc +0 -1
@@ -18,7 +18,6 @@ BUSYBOX_SPLIT_SUID ?= "1"
 export EXTRA_CFLAGS = "${CFLAGS}"
 export EXTRA_LDFLAGS = "${LDFLAGS}"
 
-# We don't want '-e MAKEFLAGS=' in EXTRA_OEMAKE
 EXTRA_OEMAKE = "CC='${CC}' LD='${CCLD}' V=1 ARCH=${TARGET_ARCH} CROSS_COMPILE=${TARGET_PREFIX} SKIP_STRIP=y HOSTCC='${BUILD_CC}' HOSTCPP='${BUILD_CPP}'"

Given that the comment presumably was there to explain why "EXTRA_OEMAKE = ..." is used rather than the customary "EXTRA_OEMAKE += ...", maybe the code should be changed to actually use += instead now that EXTRA_OEMAKE no longer contains -e by default.

Quoted 3 lines
meta/recipes-core/busybox/busybox.inc +0 -1
 PACKAGES =+ "${PN}-httpd ${PN}-udhcpd ${PN}-udhcpc ${PN}-syslog ${PN}-mdev ${PN}-hwclock"
--

1.9.1

//Peter