Skip to contentSkip to conversation

rpi-config: fix invalid shell variable name

PATCH Superseded Andrea Galbusera 2 participants 2 messages Apr 4, 2017

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rpi-config: fix invalid shell variable name

Commit da32aac introduced an invalid shell variable name in do_deploy():
according to bash manpage variable names cannot contain dots. Replace dot with underscore to fix it.

---
 recipes-bsp/bootfiles/rpi-config_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-bsp/bootfiles/rpi-config_git.bb +1 -1
index 8adc938..af55983 100644
@@ -112,7 +112,7 @@ do_deploy() {
     fi
 
     # Waveshare "C" 1024x600 7" Rev2.1 IPS capacitive touch (http://www.waveshare.com/7inch-HDMI-LCD-C.htm)
-    if [ "${WAVESHARE_1024X600_C_2.1}" = "1" ]; then
+    if [ "${WAVESHARE_1024X600_C_2_1}" = "1" ]; then
         echo "# Waveshare \"C\" 1024x600 7\" Rev2.1 IPS capacitive touch screen" >> ${DEPLOYDIR}/bcm2835-bootfiles/config.txt
         echo "max_usb_current=1" >> ${DEPLOYDIR}/bcm2835-bootfiles/config.txt
         echo "hdmi_group=2" >> ${DEPLOYDIR}/bcm2835-bootfiles/config.txt
Signature · 1 line
2.7.4
#1 lore raw
Quoted 14 lines · On Tue, 4 Apr 2017 16:18:03 +0200 Andrea Galbusera <[email protected]> wrote:

Commit da32aac introduced an invalid shell variable name in do_deploy():
according to bash manpage variable names cannot contain dots. Replace dot with underscore to fix it.

---
 recipes-bsp/bootfiles/rpi-config_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-bsp/bootfiles/rpi-config_git.bb +0 -0
index 8adc938..af55983 100644

recipes-bsp/bootfiles/rpi-config_git.bb do_deploy() { · line 118

Quoted 8 lines
recipes-bsp/bootfiles/rpi-config_git.bb +1 -1
@@ -112,7 +112,7 @@ do_deploy() {
     fi
 
     # Waveshare "C" 1024x600 7" Rev2.1 IPS capacitive touch (http://www.waveshare.com/7inch-HDMI-LCD-C.htm)
-    if [ "${WAVESHARE_1024X600_C_2.1}" = "1" ]; then
+    if [ "${WAVESHARE_1024X600_C_2_1}" = "1" ]; then
         echo "# Waveshare \"C\" 1024x600 7\" Rev2.1 IPS capacitive touch screen" >> ${DEPLOYDIR}/bcm2835-bootfiles/config.txt
         echo "max_usb_current=1" >> ${DEPLOYDIR}/bcm2835-bootfiles/config.txt
         echo "hdmi_group=2" >> ${DEPLOYDIR}/bcm2835-bootfiles/config.txt

Commit da32aac also added a note to the readme file which needs changing to match the new name, otherwise looks good.