ASoC: fsl_ssi: Remove an outdated comment
Subsystems (3)
Fabio Estevam
reviewerPATCH v2 1/2 ASoC: fsl_ssi: Remove an outdated comment
From: Fabio Estevam <[email protected]>
The comment for the FSLSSI_I2S_RATES definition states that the driver currently only supports I2S slave mode, which is no longer correct.
Remove such outdated comment.
Signed-off-by Fabio Estevam <[email protected]>
---
Changes since v1:
- Only remove the outdated part of the comment
sound/soc/fsl/fsl_ssi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
sound/soc/fsl/fsl_ssi.c +2 -4
@@ -57,10 +57,8 @@/** * FSLSSI_I2S_RATES: sample rates supported by the I2S * -* This driver currently only supports the SSI running in I2S slave mode, -* which means the codec determines the sample rate. Therefore, we tell -* ALSA that we support all rates and let the codec driver decide what rates -* are really supported. +* Tell ALSA that we support all rates and let the codec driver decide what +* rates are really supported. */ #define FSLSSI_I2S_RATES SNDRV_PCM_RATE_CONTINUOUS
Signature · 1 line
2.7.4
Fabio Estevam
reviewerPATCH v2 2/2 ASoC: fsl_ssi: Use the tolower() function
From: Fabio Estevam <[email protected]>
Code can be simplified by using the standard tolower() funtion.
Signed-off-by Fabio Estevam <[email protected]>
---
Changes since v1:
- None
sound/soc/fsl/fsl_ssi.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)
sound/soc/fsl/fsl_ssi.c +5 -8
@@ -35,6 +35,7 @@#include <linux/module.h> #include <linux/interrupt.h> #include <linux/clk.h> +#include <linux/ctype.h> #include <linux/device.h> #include <linux/delay.h> #include <linux/slab.h>
@@ -1323,14 +1324,10 @@ static struct snd_ac97_bus_ops fsl_ssi_ac97_ops = {*/ static void make_lowercase (char *s) { -char *p = s; -char c; - -while ((c = *p)) { -if ((c >='A' ) && (c <='Z' )) - *p = c + ('a' -'A' ); - p++; - } +if (!s) +return ; +for (; *s; s++) + *s =tolower (*s); } static int fsl_ssi_imx_probe(struct platform_device *pdev,
Signature · 1 line
2.7.4