Skip to contentSkip to conversation

Fix: ctf writer test on Cygwin

PATCH Michael Jeanson 2 participants 3 messages Apr 10, 2017 – May 26, 2017 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 23 lines · Michael Jeanson

In the ctf writer test we execl() some libtool wrappers that get confused when arg[0] is not the full path to the binary.

---
 tests/lib/test_ctf_writer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/lib/test_ctf_writer.c +1 -1
index 961df79..53613c9 100644
@@ -94,7 +94,7 @@ void validate_metadata(char *parser_path, char *metadata_path)
 			goto result;
 		}
 
-		execl(parser_path, "ctf-parser-test", (char *) NULL);
+		execl(parser_path, parser_path, (char *) NULL);
 		perror("# Could not launch the ctf metadata parser process");
 		exit(-1);
 	}

tests/lib/test_ctf_writer.c void validate_trace(char *parser_path, char *trace_path) · line 207

Quoted 8 lines
tests/lib/test_ctf_writer.c +1 -1
@@ -201,7 +201,7 @@ void validate_trace(char *parser_path, char *trace_path)
 			goto result;
 		}
 
-		execl(parser_path, "babeltrace", trace_path, (char *) NULL);
+		execl(parser_path, parser_path, trace_path, (char *) NULL);
 		perror("# Could not launch the babeltrace process");
 		exit(-1);
 	}

You can hold on merging this patch for now, I think it's only useful for a very specific environment which might not be worth supporting.

Michael
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

Merged in stable-1.5. Thanks!

Jérémie

Quoted 10 lines · Michael Jeanson
Quoted 4 lines · Michael Jeanson

You can hold on merging this patch for now, I think it's only useful for a very specific environment which might not be worth supporting.

Scratch that, it's needed after all, sorry for the noise.

Michael

Signature · 7 lines
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev