Skip to contentSkip to conversation

drm/amdgpu: reserve space before adding a shared fence

PATCH In review Junwei Zhang 2 participants 4 messages Apr 10, 2017 – Apr 19, 2017 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: reserve space before adding a shared fence

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +3 -0
index 157ae50..55af909 100644
@@ -913,6 +913,9 @@ static int amdgpu_vm_update_level(struct amdgpu_device *adev,
 		if (shadow)
 			amdgpu_sync_resv(adev, &job->sync, shadow->tbo.resv,
 					 AMDGPU_FENCE_OWNER_VM);
+		r = reservation_object_reserve_shared(parent->bo->tbo.resv);
+		if (r)
+			goto error_free;
 
 		WARN_ON(params.ib->length_dw > ndw);
 		r = amdgpu_job_submit(job, ring, &vm->entity,
Signature · 6 lines
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1491807259-7139-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Mhm, did you run into an actual issue or was that just from reading the code?

The caller should have reserved a shared slot before calling amdgpu_vm_update_directories() and I just double checked that and we seem to do this everywhere.

Regards,
Christian.

Am 10.04.2017 um 08:54 schrieb Junwei Zhang:

Quoted 10 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 +++
  1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +0 -0
index 157ae50..55af909 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c static int amdgpu_vm_update_level(struct amdgpu_device *adev, · line 921

Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +3 -0
@@ -913,6 +913,9 @@ static int amdgpu_vm_update_level(struct amdgpu_device *adev,
  		if (shadow)
  			amdgpu_sync_resv(adev, &job->sync, shadow->tbo.resv,
  					 AMDGPU_FENCE_OWNER_VM);
+		r = reservation_object_reserve_shared(parent->bo->tbo.resv);
+		if (r)
+			goto error_free;
 
  		WARN_ON(params.ib->length_dw > ndw);
  		r = amdgpu_job_submit(job, ring, &vm->entity,

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 9574da1c-a3a1-f4d3-1d41-695e73c732e0-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org

#4 lore raw
Quoted 1 line · Christian König

Mhm, did you run into an actual issue or was that just from reading the code?

Just reading the code. (maybe adding the prefix [RFC] is better)

Usually it is called near the amdgpu_bo_fence(), but I didn't find it in amdgpu_vm_update_level()(now for multi-level PT)

Jerry

Quoted 14 lines

The caller should have reserved a shared slot before calling amdgpu_vm_update_directories() and I just double checked that and we seem to do this everywhere.

Regards,
Christian.

Am 10.04.2017 um 08:54 schrieb Junwei Zhang:

Quoted 5 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 +++
  1 file changed, 3 insertions(+)
Quoted 17 lines
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +0 -0
index 157ae50..55af909 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c static int amdgpu_vm_update_level(struct amdgpu_device · line 921

Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +3 -0
@@ -913,6 +913,9 @@ static int amdgpu_vm_update_level(struct amdgpu_device
 *adev,
          if (shadow)
              amdgpu_sync_resv(adev, &job->sync, shadow->tbo.resv,
                       AMDGPU_FENCE_OWNER_VM);
+        r = reservation_object_reserve_shared(parent->bo->tbo.resv);
+        if (r)
+            goto error_free;
          WARN_ON(params.ib->length_dw > ndw);
          r = amdgpu_job_submit(job, ring, &vm->entity,

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw

Re: SPAM //Re: [PATCH] drm/amdgpu: reserve space before adding a shared fence

Am 10.04.2017 um 09:11 schrieb Zhang, Jerry (Junwei):

Quoted 4 lines · Christian König
Quoted 1 line

Mhm, did you run into an actual issue or was that just from reading the code?

Just reading the code. (maybe adding the prefix [RFC] is better)

Yeah, that is usually a good idea, but I'm forgetting it all the time as well.

Quoted 2 lines

Usually it is called near the amdgpu_bo_fence(), but I didn't find it in amdgpu_vm_update_level()(now for multi-level PT)

Ok, in this case that shouldn't be an issue.

Christian.

Quoted 35 lines

Jerry

Quoted 14 lines

The caller should have reserved a shared slot before calling amdgpu_vm_update_directories() and I just double checked that and we seem to do this everywhere.

Regards,
Christian.

Am 10.04.2017 um 08:54 schrieb Junwei Zhang:

Quoted 5 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 +++
  1 file changed, 3 insertions(+)
Quoted 18 lines
Quoted 11 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +0 -0
index 157ae50..55af909 100644
@@ -913,6 +913,9 @@ static int amdgpu_vm_update_level(struct 

amdgpu_device
*adev,

          if (shadow)
              amdgpu_sync_resv(adev, &job->sync, shadow->tbo.resv,
                       AMDGPU_FENCE_OWNER_VM);

drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c static int amdgpu_vm_update_level(struct amdgpu_device *adev, · line 921

Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +3 -0
+        r = reservation_object_reserve_shared(parent->bo->tbo.resv);
+        if (r)
+            goto error_free;
          WARN_ON(params.ib->length_dw > ndw);
          r = amdgpu_job_submit(job, ring, &vm->entity,
Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx