Skip to contentSkip to conversation

Patch "mtd: bcm47xxpart: fix parsing first block after aligned TRX" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Apr 12, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mtd: bcm47xxpart: fix parsing first block after aligned TRX

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mtd-bcm47xxpart-fix-parsing-first-block-after-aligned-trx.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From bd5d21310133921021d78995ad6346f908483124 Mon Sep 17 00:00:00 2001

From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <[email protected]>
Date: Sun, 20 Nov 2016 16:09:30 +0100
Subject: mtd: bcm47xxpart: fix parsing first block after aligned TRX
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Rafał Miłecki <[email protected]>

commit bd5d21310133921021d78995ad6346f908483124 upstream.

After parsing TRX we should skip to the first block placed behind it. Our code was working only with TRX with length not aligned to the blocksize. In other cases (length aligned) it was missing the block places right after TRX.

This fixes calculation and simplifies the comment.

---
 drivers/mtd/bcm47xxpart.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/mtd/bcm47xxpart.c +4 -6
@@ -225,12 +225,10 @@ static int bcm47xxpart_parse(struct mtd_
 
 			last_trx_part = curr_part - 1;
 
-			/*
-			 * We have whole TRX scanned, skip to the next part. Use
-			 * roundown (not roundup), as the loop will increase
-			 * offset in next step.
-			 */
-			offset = rounddown(offset + trx->length, blocksize);
+			/* Jump to the end of TRX */
+			offset = roundup(offset + trx->length, blocksize);
+			/* Next loop iteration will increase the offset */
+			offset -= blocksize;
 			continue;
 		}
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/mtd-bcm47xxpart-fix-parsing-first-block-after-aligned-trx.patch