Skip to contentSkip to conversation

Patch "Input: gscps2 - fix MODULE_DEVICE_TABLE invocation" has been added to the 3.18-stable tree

PATCH [email protected] 1 participant 1 message Apr 17, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Input: gscps2 - fix MODULE_DEVICE_TABLE invocation

to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
input-gscps2-fix-module_device_table-invocation.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 6c8afa88adce613c23f27e719f805cc2a6441b07 Mon Sep 17 00:00:00 2001

From: Geert Uytterhoeven <[email protected]>
Date: Wed, 4 Feb 2015 10:59:25 -0800
Subject: Input: gscps2 - fix MODULE_DEVICE_TABLE invocation

From: Geert Uytterhoeven <[email protected]>

commit 6c8afa88adce613c23f27e719f805cc2a6441b07 upstream.

The patch "module: fix types of device tables aliases" newly requires that invocations of

MODULE_DEVICE_TABLE(type, name);

come *after* the definition of `name'. That is reasonable, but gscps2 wasn't doing this. Fix it.

---
 drivers/input/serio/gscps2.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/serio/gscps2.c +1 -1
@@ -40,7 +40,6 @@
 MODULE_AUTHOR("Laurent Canet <[email protected]>, Thibaut Varene <[email protected]>, Helge Deller <[email protected]>");
 MODULE_DESCRIPTION("HP GSC PS2 port driver");
 MODULE_LICENSE("GPL");
-MODULE_DEVICE_TABLE(parisc, gscps2_device_tbl);
 
 #define PFX "gscps2.c: "
 
@@ -439,6 +438,7 @@ static struct parisc_device_id gscps2_de
 #endif
 	{ 0, }	/* 0 terminated list */
 };
+MODULE_DEVICE_TABLE(parisc, gscps2_device_tbl);
 
 static struct parisc_driver parisc_ps2_driver = {
 	.name		= "gsc_ps2",

Patches currently in stable-queue which might be from [email protected] are

queue-3.18/input-gscps2-fix-module_device_table-invocation.patch