Skip to contentSkip to conversation

Patch "perf/x86: Avoid exposing wrong/stale data in intel_pmu_lbr_read_32()" has been added to the 4.10-stable tree

PATCH [email protected] 1 participant 1 message Apr 18, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

perf/x86: Avoid exposing wrong/stale data in intel_pmu_lbr_read_32()

to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
perf-x86-avoid-exposing-wrong-stale-data-in-intel_pmu_lbr_read_32.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From f2200ac311302fcdca6556fd0c5127eab6c65a3e Mon Sep 17 00:00:00 2001

From: Peter Zijlstra <[email protected]>
Date: Tue, 11 Apr 2017 10:10:28 +0200
Subject: perf/x86: Avoid exposing wrong/stale data in intel_pmu_lbr_read_32()

From: Peter Zijlstra <[email protected]>

commit f2200ac311302fcdca6556fd0c5127eab6c65a3e upstream.

When the perf_branch_entry::{in_tx,abort,cycles} fields were added, intel_pmu_lbr_read_32() wasn't updated to initialize them.

Cc Linus Torvalds <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Thomas Gleixner <[email protected]>
Fixes 135c5612c460 ("perf/x86/intel: Support Haswell/v4 LBR format")
---
 arch/x86/events/intel/lbr.c |    3 +++
 1 file changed, 3 insertions(+)
arch/x86/events/intel/lbr.c +3 -0
@@ -507,6 +507,9 @@ static void intel_pmu_lbr_read_32(struct
 		cpuc->lbr_entries[i].to		= msr_lastbranch.to;
 		cpuc->lbr_entries[i].mispred	= 0;
 		cpuc->lbr_entries[i].predicted	= 0;
+		cpuc->lbr_entries[i].in_tx	= 0;
+		cpuc->lbr_entries[i].abort	= 0;
+		cpuc->lbr_entries[i].cycles	= 0;
 		cpuc->lbr_entries[i].reserved	= 0;
 	}
 	cpuc->lbr_stack.nr = i;

Patches currently in stable-queue which might be from [email protected] are

queue-4.10/x86-efi-don-t-try-to-reserve-runtime-regions.patch queue-4.10/x86-signals-fix-lower-upper-bound-reporting-in-compat-siginfo.patch queue-4.10/perf-annotate-s390-fix-perf-annotate-error-95-4.10-regression.patch queue-4.10/x86-vdso-ensure-vdso32_enabled-gets-set-to-valid-values-only.patch queue-4.10/x86-vdso-plug-race-between-mapping-and-elf-header-setup.patch queue-4.10/x86-intel_rdt-fix-locking-in-rdtgroup_schemata_write.patch queue-4.10/cgroup-kthread-close-race-window-where-new-kthreads-can-be-migrated-to-non-root-cgroups.patch queue-4.10/perf-x86-avoid-exposing-wrong-stale-data-in-intel_pmu_lbr_read_32.patch