rdma-core: libibumad symbols version downgrade

DISCUSSION Benjamin Drung 3 participants 3 messages Apr 18, 2017 – Apr 19, 2017 2 messages not in the archive InfiniBand

lore

Share & tools

lore

Benjamin Drung

author

2017-04-18 17:55 UTC #0 lore raw

Hi,

while reviewing the Debian packaging changes from libibumad 1.3.10.2-2 to rdma-core, I stumbled over the symbols version. libibumad 1.3.10.2 ships libibumad.so.3.1.0, but rdma-core ships libibumad.so.3.0.14 which is lower. Is that intentional?

Signature · 18 lines

Benjamin Drung
System Developer
Debian & Ubuntu Developer

ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin

Email: [email protected]
URL:  http://www.profitbricks.com

Sitz der Gesellschaft: Berlin.
Registergericht: Amtsgericht Charlottenburg, HRB 125506B.
Geschäftsführer: Andreas Gauger, Achim Weiss.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Leon Romanovsky

2017-04-19 10:04 UTC #2 lore raw

Quoted 6 lines · Benjamin Drung

Hi,
while reviewing the Debian packaging changes from libibumad 1.3.10.2-2 to rdma-core, I stumbled over the symbols version. libibumad 1.3.10.2 ships libibumad.so.3.1.0, but rdma-core ships libibumad.so.3.0.14 which is lower. Is that intentional?

I don't think so. It should be 3.1.${PACKAGE_VERSION}.

Thanks

Quoted 20 lines

--
Benjamin Drung
System Developer
Debian & Ubuntu Developer
ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin
Email: [email protected]
URL: http://www.profitbricks.com
Sitz der Gesellschaft: Berlin.
Registergericht: Amtsgericht Charlottenburg, HRB 125506B. Geschäftsführer: Andreas Gauger, Achim Weiss.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20170419100430.GI14088-U/[email protected]

Jason Gunthorpe

2017-04-19 15:36 UTC #4 lore raw

Quoted 7 lines · Leon Romanovsky

Quoted 6 lines · Benjamin Drung
Hi,
while reviewing the Debian packaging changes from libibumad 1.3.10.2-2 to rdma-core, I stumbled over the symbols version. libibumad 1.3.10.2 ships libibumad.so.3.1.0, but rdma-core ships libibumad.so.3.0.14 which is lower. Is that intentional?

It was intentional:

commit 232796a623f28bd205d15acac44bb007b8fc64be

Author: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Date:   Mon Jan 30 11:04:21 2017 -0700

Fix shared library filenames

We expect the filename to reflect the symbol versions in the file, this means, eg libibverbs1.3 should have the IBVERBS_1.3 as the newest symbol. The same applies to all libraries.

verbs was not updated in commit 3ca7a103148 when new symbols were added

umad/rdmacm probably legitimately had a '.1' someday, but failed to follow symver convention. Bump it back down.

Since distros are not using it in packaging the shared library version and filename is no longer used by anything. We simply want it to follow our own internal conventions.

Fixes 3ca7a1031486 ("ibverbs: Add support for packet pacing")

Signed-off-by Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html