Skip to contentSkip to conversation

Patch "Reset TreeId to zero on SMB2 TREE_CONNECT" has been added to the 3.18-stable tree

PATCH [email protected] 1 participant 1 message Apr 18, 2017 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Reset TreeId to zero on SMB2 TREE_CONNECT

to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
reset-treeid-to-zero-on-smb2-tree_connect.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 806a28efe9b78ffae5e2757e1ee924b8e50c08ab Mon Sep 17 00:00:00 2001

From: Jan-Marek Glogowski <[email protected]>
Date: Mon, 20 Feb 2017 12:25:58 +0100
Subject: Reset TreeId to zero on SMB2 TREE_CONNECT

From: Jan-Marek Glogowski <[email protected]>

commit 806a28efe9b78ffae5e2757e1ee924b8e50c08ab upstream.

Currently the cifs module breaks the CIFS specs on reconnect as described in http://msdn.microsoft.com/en-us/library/cc246529.aspx:

"TreeId (4 bytes): Uniquely identifies the tree connect for the command. This MUST be 0 for the SMB2 TREE_CONNECT Request."

---
 fs/cifs/smb2pdu.c |    4 ++++
 1 file changed, 4 insertions(+)
fs/cifs/smb2pdu.c +4 -0
@@ -868,6 +868,10 @@ SMB2_tcon(const unsigned int xid, struct
 		return -EINVAL;
 	}
 
+	/* SMB2 TREE_CONNECT request must be called with TreeId == 0 */
+	if (tcon)
+		tcon->tid = 0;
+
 	rc = small_smb2_init(SMB2_TREE_CONNECT, tcon, (void **) &req);
 	if (rc) {
 		kfree(unc_path);

Patches currently in stable-queue which might be from [email protected] are

queue-3.18/reset-treeid-to-zero-on-smb2-tree_connect.patch