Skip to contentSkip to conversation

drm/amd/powerplay: add error message to remind user updating firmware

PATCH In review Huang Rui 4 participants 4 messages Apr 20, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Huang Rui

author
#0 lore raw

PATCH 1/1 drm/amd/powerplay: add error message to remind user updating firmware

---
 drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c +5 -2
index 2685f02..b3f3af2 100644
@@ -378,8 +378,11 @@ static int vega10_verify_smc_interface(struct pp_smumgr *smumgr)
 			"Attempt to read SMC IF Version Number Failed!",
 			return -1);
 
-	if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
-		return -1;
+	if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
+		pr_err("Your firmware(0x%x) doesn't match SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
+		       smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
+		return -EINVAL;
+	}
 
 	return 0;
 }
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1492673633-21017-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org

Reviewed-by Evan Quan
#2 lore raw
Quoted 35 lines

-----Original Message-----
From: Huang Rui [mailto:[email protected]]
Sent: Thursday, April 20, 2017 3:34 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Quan, Evan <[email protected]>; Huang, Ray <[email protected]>
Subject: [PATCH] drm/amd/powerplay: add error message to remind user updating firmware

---
drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +++++--

1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c +5 -2
index 2685f02..b3f3af2 100644
@@ -378,8 +378,11 @@ static int vega10_verify_smc_interface(struct
 pp_smumgr *smumgr)
 			"Attempt to read SMC IF Version Number Failed!",
 			return -1);
 
-	if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
-		return -1;
+	if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
+		pr_err("Your firmware(0x%x) doesn't match
 SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
+		       smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
+		return -EINVAL;
+	}
 
	return 0;
}
Quoted 2 lines

--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#3 lore raw
In reply to a message not in the archive
Quoted 14 lines · Huang Rui
---
 drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c +0 -0
index 2685f02..b3f3af2 100644
@@ -378,8 +378,11 @@ static int vega10_verify_smc_interface(struct pp_smumgr *smumgr)
 			"Attempt to read SMC IF Version Number Failed!",
 			return -1);
 

drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c static int vega10_verify_smc_interface(struct pp_smumgr *smumgr) · line 388

Quoted 10 lines
drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c +5 -2
-	if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
-		return -1;
+	if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
+		pr_err("Your firmware(0x%x) doesn't match SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
+		       smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
+		return -EINVAL;
+	}
 
 	return 0;
 }

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#4 lore raw
In reply to a message not in the archive
Quoted 1 line · Huang Rui
Quoted 25 lines
---
 drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c +5 -3
index 2685f02..b3f3af2 100644
@@ -378,8 +378,11 @@ static int vega10_verify_smc_interface(struct pp_smumgr *smumgr)
                        "Attempt to read SMC IF Version Number Failed!",
                        return -1);
 
-       if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
-               return -1;
+       if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
+               pr_err("Your firmware(0x%x) doesn't match SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
+                      smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
+               return -EINVAL;
+       }
 
        return 0;
 }
--

2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx