Skip to contentSkip to conversation

SCSI fixes for 4.11-rc8

GIT PULL James Bottomley 1 participant 1 message Apr 24, 2017 SCSI

lore
Share & tools
lore

James Bottomley

author maintainer
#0 lore raw

Our final fix before the 4.12 release (hopefully). It's an error leg
again: the fix to not bug on empty DMA transfers is returning the wrong code and confusing the block layer.

The patch is available here:

git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes

The short changelog is:

Johannes Thumshirn (1):
scsi: return correct blkprep status code in case scsi_init_io() fails.

With the diffstat:

 drivers/scsi/scsi_lib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

And full diff below.

James

---

drivers/scsi/scsi_lib.c +2 -2
index 19125d72f322..5558e212368b 100644
@@ -1061,10 +1061,10 @@ int scsi_init_io(struct scsi_cmnd *cmd)
 	struct scsi_device *sdev = cmd->device;
 	struct request *rq = cmd->request;
 	bool is_mq = (rq->mq_ctx != NULL);
-	int error;
+	int error = BLKPREP_KILL;
 
 	if (WARN_ON_ONCE(!blk_rq_nr_phys_segments(rq)))
-		return -EINVAL;
+		goto err_exit;
 
 	error = scsi_init_sgtable(rq, &cmd->sdb);
 	if (error)