drm/radeon: reject bo creation from ioctl when the gpu is disabled
Subsystems (2)
PATCH 1/1 drm/radeon: reject bo creation from ioctl when the gpu is disabled
Like done in radeon_cs_ioctl.
In particular it avoids mesa to call map/unmap:
radeon_create_bo
ioctl(DRM_RADEON_GEM_CREATE) -> ok
ioctl(DRM_RADEON_GEM_VA-MAP) radeon_destroy_bo
ioctl(DRM_RADEON_GEM_VA-UNMAP)
Encountered also cases where the vm_manager succeeded to be enabled after a gpu reset while the GFX ring was not responding so accel was disabled.
https://bugs.freedesktop.org/show_bug.cgi?id=96271
--- drivers/gpu/drm/radeon/radeon_gem.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/gpu/drm/radeon/radeon_gem.c +7 -0
@@ -259,6 +259,13 @@ int radeon_gem_create_ioctl(struct drm_device *dev, void *data,int r;down_read (&rdev->exclusive_lock); + +if (!rdev->accel_working && + args->initial_domain !=RADEON_GEM_DOMAIN_CPU ) { +up_read (&rdev->exclusive_lock); +return -EBUSY ; + } +/* create a gem object to contain this object in */ args->size =roundup (args->size,PAGE_SIZE ); r = radeon_gem_object_create(rdev, args->size, args->alignment,
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1493290672-22387-1-git-send-email-jisorce-bXq66PvbRDbQT0dZR+AlfA@public.gmane.org
Christian König
NAKAm 27.04.2017 um 12:57 schrieb Julien Isorce:
Quoted 9 lines
Like done in
radeon_cs_ioctl.In particular it avoids mesa to call map/unmap:
radeon_create_bo ioctl(DRM_RADEON_GEM_CREATE) -> ok ioctl(DRM_RADEON_GEM_VA-MAP) radeon_destroy_bo ioctl(DRM_RADEON_GEM_VA-UNMAP)
Quoted 4 lines
Encountered also cases where the
vm_managersucceeded to be enabled after a gpu reset while the GFX ring was not responding so accel was disabled.
NAK, even if accel isn't working we want to display something and for that we need to be able to create BOs.
Christian.
Quoted 14 lines
Signed-off-by Julien Isorce <[email protected]>--- drivers/gpu/drm/radeon/radeon_gem.c | 7 +++++++ 1 file changed, 7 insertions(+)drivers/gpu/drm/radeon/radeon_gem.c +0
-0@@ -259,6 +259,13 @@ int radeon_gem_create_ioctl(struct drm_device *dev, void *data,int r;down_read (&rdev->exclusive_lock);
drivers/gpu/drm/radeon/radeon_gem.c int radeon_gem_create_ioctl(struct drm_device *dev, void *data, · line 271
Quoted 10 lines
drivers/gpu/drm/radeon/radeon_gem.c +7
-0+ +if (!rdev->accel_working && + args->initial_domain !=RADEON_GEM_DOMAIN_CPU ) { +up_read (&rdev->exclusive_lock); +return -EBUSY ; + } +/* create a gem object to contain this object in */ args->size =roundup (args->size,PAGE_SIZE ); r = radeon_gem_object_create(rdev, args->size, args->alignment,
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx