Skip to contentSkip to conversation

Patch "net/mlx5: Fix driver load bad flow when having fw initializing timeout" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Apr 30, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net/mlx5: Fix driver load bad flow when having fw initializing timeout

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-mlx5-fix-driver-load-bad-flow-when-having-fw-initializing-timeout.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Sun Apr 30 15:46:17 CEST 2017

From: Mohamad Haj Yahia <[email protected]>
Date: Thu, 30 Mar 2017 17:00:25 +0300
Subject: net/mlx5: Fix driver load bad flow when having fw initializing timeout

From: Mohamad Haj Yahia <[email protected]>

[ Upstream commit 55378a238e04b39cc82957d91d16499704ea719b ]

If FW is stuck in initializing state we will skip the driver load, but current error handling flow doesn't clean previously allocated command interface resources.

Fixes e3297246c2c8 ('net/mlx5_core: Wait for FW readiness on startup')
---
 drivers/net/ethernet/mellanox/mlx5/core/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/main.c +1 -1
@@ -944,7 +944,7 @@ static int mlx5_load_one(struct mlx5_cor
 	if (err) {
 		dev_err(&dev->pdev->dev, "Firmware over %d MS in initializing state, aborting\n",
 			FW_INIT_TIMEOUT_MILI);
-		goto out_err;
+		goto err_cmd_cleanup;
 	}
 
 	mlx5_pagealloc_init(dev);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/net-mlx5-fix-driver-load-bad-flow-when-having-fw-initializing-timeout.patch