Skip to contentSkip to conversation

Patch "sctp: listen on the sock only when it's state is listening or closed" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Apr 30, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

sctp: listen on the sock only when it's state is listening or closed

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
sctp-listen-on-the-sock-only-when-it-s-state-is-listening-or-closed.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Sun Apr 30 15:46:17 CEST 2017

From: Xin Long <[email protected]>
Date: Thu, 6 Apr 2017 13:10:52 +0800
Subject: sctp: listen on the sock only when it's state is listening or closed

From: Xin Long <[email protected]>

[ Upstream commit 34b2789f1d9bf8dcca9b5cb553d076ca2cd898ee ]

Now sctp doesn't check sock's state before listening on it. It could even cause changing a sock with any state to become a listening sock when doing sctp_listen.

This patch is to fix it by checking sock's state in sctp_listen, so that it will listen on the sock with right state.

---
 net/sctp/socket.c |    3 +++
 1 file changed, 3 insertions(+)
net/sctp/socket.c +3 -0
@@ -6394,6 +6394,9 @@ int sctp_inet_listen(struct socket *sock
 	if (sock->state != SS_UNCONNECTED)
 		goto out;
 
+	if (!sctp_sstate(sk, LISTENING) && !sctp_sstate(sk, CLOSED))
+		goto out;
+
 	/* If backlog is zero, disable listening. */
 	if (!backlog) {
 		if (sctp_sstate(sk, CLOSED))

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/sctp-listen-on-the-sock-only-when-it-s-state-is-listening-or-closed.patch