staging: rtl8192u: ieee80211: rtl819x_TSProc: Fixed coding style issue
PATCH 1/1 staging: rtl8192u: ieee80211: rtl819x_TSProc: Fixed coding style issue
Fixed checkpatch.pl issue
ERROR: that open brace { should be on the previous line
--- drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c +1 -2
@@ -338,8 +338,7 @@ bool GetTs(else {// In WMM case: we use 4 TID only -if (!IsACValid (TID )) - { +if (!IsACValid (TID )) {IEEE80211_DEBUG (IEEE80211_DL_ERR ," in %s(), TID(%d) is not valid\n" , __func__,TID );return false; }
Signature · 1 line
1.9.1
Quoted 2 lines · Fabrizio Perria
Fixed checkpatch.pl issue
ERROR: that open brace { should be on the previous line
[]
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
Quoted 1 line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c +0
-0
[]
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c bool GetTs( · line 344
Quoted 10 lines
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c +1
-2@@ -338,8 +338,7 @@ bool GetTs(else {// In WMM case: we use 4 TID only -if (!IsACValid (TID )) - { +if (!IsACValid (TID )) {IEEE80211_DEBUG (IEEE80211_DL_ERR ," in %s(), TID(%d) is not valid\n" , __func__,TID );return false; }
Why fix only one of these?
$ ./scripts/checkpatch.pl --show-types --strict --types=else_after_brace,open_brace,braces --terse \ -f drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:39: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:42: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:48: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:62: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:62: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:70: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:84: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:150: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:175: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:194: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:203: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:226: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:228: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:233: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:233: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:239: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:239: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:246: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:246: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:248: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:254: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:254: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:268: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:276: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:282: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:287: WARNING:BRACES: braces {} are not necessary for any arm of this statement drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:290: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:330: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:338: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:341: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:347: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:376: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:380: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:380: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:386: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:386: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:409: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:413: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:418: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:418: CHECK:BRACES: Unbalanced braces around else statement drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:442: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:442: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:460: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:468: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:477: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:482: WARNING:BRACES: braces {} are not necessary for single statement blocks drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:494: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:494: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:506: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:508: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:516: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:518: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:527: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:529: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:537: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:539: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:552: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:559: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:566: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:573: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:583: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:586: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:592: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:592: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:598: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
total: 60 errors, 2 warnings, 3 checks, 600 lines checked