x86/intel_rdt: Fix a typo in Documentation
PATCH 1/1 x86/intel_rdt: Fix a typo in Documentation
The typo is in example 3.
"C0" in "# echo C0 > p0/cpus" is wrong because it specifies core 6-7 instead of wanted core 4-7.
Correct this typo to avoid confusion.
--- Documentation/x86/intel_rdt_ui.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/x86/intel_rdt_ui.txt +1 -1
@@ -295,7 +295,7 @@ kernel and the tasks running there get 50% of the cache. They should also get 50% of memory bandwidth assuming that the cores 4-7 are SMT siblings and only the real time threads are scheduled on the cores 4-7. -# echo C0 > p0/cpus +# echo F0 > p0/cpus 4) Locking between applications
Signature · 1 line
1.8.3.1
Quoted 9 lines · Xiaochen Shen
The typo is in example 3.
"C0" in "# echo C0 > p0/cpus" is wrong because it specifies core 6-7 instead of wanted core 4-7.
Correct this typo to avoid confusion.
Signed-off-by Xiaochen Shen <[email protected]>Signed-off-by Fenghua Yu <[email protected]>
That SOB chain is wrong.
Thanks,
tglx
Hi Thomas,
I am sorry, this is the reason why I added Fenghua in SOB list:
I have sent this patch to Fenghua for internal review. After that, I sent it out to LKML.
What is your suggestion to fix? Move Fenghua from "Signed-off-by:" to "Cc:"? Thank you.
Best regards,
Xiaochen
Quoted 18 lines · Thomas Gleixner
Quoted 9 lines · Xiaochen Shen
The typo is in example 3.
"C0" in "# echo C0 > p0/cpus" is wrong because it specifies core 6-7 instead of wanted core 4-7.
Correct this typo to avoid confusion.
Signed-off-by Xiaochen Shen <[email protected]>Signed-off-by Fenghua Yu <[email protected]>That SOB chain is wrong.
Thanks,
tglx
Quoted 5 lines · Xiaochen Shen
Hi Thomas,
I am sorry, this is the reason why I added Fenghua in SOB list:
I have sent this patch to Fenghua for internal review. After that, I sent it out to LKML.
The SOB chain would have been correct, if Fenghua would have sent your patch.
Quoted 1 line
What is your suggestion to fix? Move Fenghua from "Signed-off-by:" to "Cc:"?
Yes, and if Fenghua want's to add his acked/reviewed-by he can do this on the mailing list.
Thanks,
tglx
Thank you, Thomas. I will send out v2 patch with the fix soon.
Best regards,
Xiaochen
Quoted 20 lines · Thomas Gleixner
Quoted 5 lines · Xiaochen Shen
Hi Thomas,
I am sorry, this is the reason why I added Fenghua in SOB list:
I have sent this patch to Fenghua for internal review. After that, I sent it out to LKML.The SOB chain would have been correct, if Fenghua would have sent your patch.
Quoted 1 line
What is your suggestion to fix? Move Fenghua from "Signed-off-by:" to "Cc:"?
Yes, and if Fenghua want's to add his acked/reviewed-by he can do this on the mailing list.
Thanks,
tglx
tip-bot for Xiaochen Shen
merge botx86/intel_rdt: Fix a typo in Documentation
Commit-ID: fb8fb46c56289b3f34b5d90a4ec65e9e4e4544a5 Gitweb: http://git.kernel.org/tip/fb8fb46c56289b3f34b5d90a4ec65e9e4e4544a5 Author: Xiaochen Shen <[email protected]> AuthorDate: Wed, 3 May 2017 11:15:56 +0800 Committer: Thomas Gleixner <[email protected]> CommitDate: Tue, 9 May 2017 09:41:42 +0200
x86/intel_rdt: Fix a typo in Documentation
Example 3 contains a typo:
"C0" in "# echo C0 > p0/cpus" is wrong because it specifies core 6-7 instead of wanted core 4-7.
Correct this typo to avoid confusion.
--- Documentation/x86/intel_rdt_ui.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/x86/intel_rdt_ui.txt +1 -1
@@ -295,7 +295,7 @@ kernel and the tasks running there get 50% of the cache. They should also get 50% of memory bandwidth assuming that the cores 4-7 are SMT siblings and only the real time threads are scheduled on the cores 4-7. -# echo C0 > p0/cpus +# echo F0 > p0/cpus 4) Locking between applications