Patch "PCI: xilinx: Fix harmless format string warning" has been added to the 3.18-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
PCI: xilinx: Fix harmless format string warning
to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
pci-xilinx-fix-harmless-format-string-warning.patch
and it can be found in the queue-3.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
abc596b9a2f3d24b8b0d637bdb071aae7f09801dMon Sep 17 00:00:00 2001
From: Arnd Bergmann <[email protected]>
Date: Tue, 13 Jan 2015 15:20:05 +0100
Subject: PCI: xilinx: Fix harmless format string warning
From: Arnd Bergmann <[email protected]>
commit abc596b9a2f3d24b8b0d637bdb071aae7f09801d upstream.
The xilinx PCIe driver prints a register value whose type is propagated to the type returned by the GENMASK() macro. Unfortunately, that type has recently changed as the result of a bug fix, so now we get a warning about the type:
drivers/pci/host/pcie-xilinx.c: In function 'xilinx_pcie_clear_err_interrupts':
drivers/pci/host/pcie-xilinx.c:154:3: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]
Change the code so we always print the number as an 'unsigned long' type to avoid the warning. The original code was fine on 32-bit architectures but not on 64-bit. Now it works as expected on both.
--- drivers/pci/host/pcie-xilinx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/host/pcie-xilinx.c +2 -2
@@ -148,10 +148,10 @@ static inline bool xilinx_pcie_link_is_u*/ static void xilinx_pcie_clear_err_interrupts (struct xilinx_pcie_port *port) { -u32 val =pcie_read (port,XILINX_PCIE_REG_RPEFR ); +unsigned long val =pcie_read (port,XILINX_PCIE_REG_RPEFR );if (val &XILINX_PCIE_RPEFR_ERR_VALID ) { -dev_dbg (port->dev,"Requester ID %d\n" , +dev_dbg (port->dev,"Requester ID %lu\n" , val &XILINX_PCIE_RPEFR_REQ_ID );pcie_write (port,XILINX_PCIE_RPEFR_ALL_MASK ,XILINX_PCIE_REG_RPEFR );
Patches currently in stable-queue which might be from [email protected] are
queue-3.18/ib-iser-fix-sparse-warnings.patch queue-3.18/cred-userns-define-current_user_ns-as-a-function.patch queue-3.18/pci-xilinx-fix-harmless-format-string-warning.patch queue-3.18/alsa-ppc-awacs-shut-up-maybe-uninitialized-warning.patch queue-3.18/net-tg3-avoid-uninitialized-variable-warning.patch queue-3.18/mtd-avoid-stack-overflow-in-mtd-cfi-code.patch queue-3.18/powerpc-ptrace-fix-out-of-bounds-array-access-warning.patch queue-3.18/mlx5-avoid-build-warnings-on-32-bit.patch queue-3.18/drbd-avoid-redefinition-of-bits_per_page.patch