Skip to contentSkip to conversation

drm/amdgpu/psp: Do not load asd for SRIOV

PATCH NAK Xiangliang Yu 3 participants 4 messages May 4, 2017 – May 5, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 4/6 drm/amdgpu/psp: Do not load asd for SRIOV

If psp version doesn't match asd version, asd loading will be failed. Add workaround to bypass it for sriov.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +7 -0
index ac5e92e..5041073 100644
@@ -230,6 +230,13 @@ static int psp_asd_load(struct psp_context *psp)
 	int ret;
 	struct psp_gfx_cmd_resp *cmd;
 
+	/* If PSP version doesn't match ASD version, asd loading will be failed.
+	 * add workaround to bypass it for sriov now.
+	 * TODO: add version check to make it common
+	 */
+	if (amdgpu_sriov_vf(psp->adev))
+		return 0;
+
 	cmd = kzalloc(sizeof(struct psp_gfx_cmd_resp), GFP_KERNEL);
 	if (!cmd)
 		return -ENOMEM;
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1493879795-27012-1-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org

Reviewed-by Monk Liu
#2 lore raw

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Xiangliang Yu
Sent: Thursday, May 04, 2017 2:37 PM
To: [email protected]
Cc: Wang, Daniel(Xiaowei) <[email protected]>; Yu, Xiangliang <[email protected]>
Subject: [PATCH 4/6] drm/amdgpu/psp: Do not load asd for SRIOV

If psp version doesn't match asd version, asd loading will be failed. Add workaround to bypass it for sriov.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +7 -0
index ac5e92e..5041073 100644
@@ -230,6 +230,13 @@ static int psp_asd_load(struct psp_context *psp)
 	int ret;
 	struct psp_gfx_cmd_resp *cmd;
 
+	/* If PSP version doesn't match ASD version, asd loading will be failed.
+	 * add workaround to bypass it for sriov now.
+	 * TODO: add version check to make it common
+	 */
+	if (amdgpu_sriov_vf(psp->adev))
+		return 0;
+
 	cmd = kzalloc(sizeof(struct psp_gfx_cmd_resp), GFP_KERNEL);
 	if (!cmd)
 		return -ENOMEM;

--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw
In reply to a message not in the archive
Quoted 14 lines · Xiangliang Yu

If psp version doesn't match asd version, asd loading will be failed. Add workaround to bypass it for sriov.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +0 -0
index ac5e92e..5041073 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c static int psp_asd_load(struct psp_context *psp) · line 236

Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +4 -0
@@ -230,6 +230,13 @@ static int psp_asd_load(struct psp_context *psp)
 	int ret;
 	struct psp_gfx_cmd_resp *cmd;
 
+	/* If PSP version doesn't match ASD version, asd loading will be failed.
+	 * add workaround to bypass it for sriov now.
+	 * TODO: add version check to make it common
+	 */

Which psp version? Firmware or boot loader? Can you explain clear?

Thanks,
Rui
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#4 lore raw
Quoted 28 lines

-----Original Message-----
From: Huang Rui [mailto:[email protected]]
Sent: Friday, May 05, 2017 2:47 PM
To: Yu, Xiangliang <[email protected]>
Cc: [email protected]; Wang, Daniel(Xiaowei) <[email protected]>
Subject: Re: [PATCH 4/6] drm/amdgpu/psp: Do not load asd for SRIOV

Quoted 18 lines · Xiangliang Yu

If psp version doesn't match asd version, asd loading will be failed. Add workaround to bypass it for sriov.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +0 -0
index ac5e92e..5041073 100644
@@ -230,6 +230,13 @@ static int psp_asd_load(struct psp_context *psp)
 	int ret;
 	struct psp_gfx_cmd_resp *cmd;
 
Quoted 6 lines

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c static int psp_asd_load(struct psp_context *psp) · line 236

Quoted 4 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +4 -0
+	/* If PSP version doesn't match ASD version, asd loading will be failed.
+	 * add workaround to bypass it for sriov now.
+	 * TODO: add version check to make it common
+	 */

Which psp version? Firmware or boot loader? Can you explain clear?

SRIOV doesn't care about ASD, I'll remove the comments later to avoid confusing.

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx