drm/amdgpu: clean doorbell after sending init table to mmsch
Subsystems (2)
PATCH 6/6 drm/amdgpu: clean doorbell after sending init table to mmsch
From: Frank Min <[email protected]>
According to HW design, need to clean doorbell after setup MMSCH table.
--- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 1 + drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 1 + 2 files changed, 2 insertions(+)
drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c +1 -0
@@ -696,6 +696,7 @@ static int uvd_v7_0_mmsch_start(struct amdgpu_device *adev,dev_err (adev->dev,"failed to init MMSCH, mmVCE_MMSCH_VF_MAILBOX_RESP = %x\n" , data);return -EBUSY ; } +WDOORBELL32 (adev->uvd.ring_enc[0 ].doorbell_index,0 );return 0 ; }
drivers/gpu/drm/amd/amdgpu/vce_v4_0.c +1 -0
@@ -190,6 +190,7 @@ static int vce_v4_0_mmsch_start(struct amdgpu_device *adev,dev_err (adev->dev,"failed to init MMSCH, mmVCE_MMSCH_VF_MAILBOX_RESP = %x\n" , data);return -EBUSY ; } +WDOORBELL32 (adev->vce.ring[0 ].doorbell_index,0 );return 0 ; }
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1493879853-27106-1-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org
Liu, Monk
Reviewed-by Monk Liu-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Xiangliang Yu
Sent: Thursday, May 04, 2017 2:38 PM
To: [email protected]
Cc: Yu, Xiangliang <[email protected]>; Min, Frank <[email protected]>
Subject: [PATCH 6/6] drm/amdgpu: clean doorbell after sending init table to mmsch
From: Frank Min <[email protected]>
According to HW design, need to clean doorbell after setup MMSCH table.
--- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 1 + drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 1 + 2 files changed, 2 insertions(+)
drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c +1 -0
@@ -696,6 +696,7 @@ static int uvd_v7_0_mmsch_start(struct amdgpu_device *adev,dev_err (adev->dev,"failed to init MMSCH, mmVCE_MMSCH_VF_MAILBOX_RESP = %x\n" , data);return -EBUSY ; } +WDOORBELL32 (adev->uvd.ring_enc[0 ].doorbell_index,0 );return 0 ; }
drivers/gpu/drm/amd/amdgpu/vce_v4_0.c +1 -0
@@ -190,6 +190,7 @@ static int vce_v4_0_mmsch_start(struct amdgpu_device *adev,dev_err (adev->dev,"failed to init MMSCH, mmVCE_MMSCH_VF_MAILBOX_RESP = %x\n" , data);return -EBUSY ; } +WDOORBELL32 (adev->vce.ring[0 ].doorbell_index,0 );return 0 ; }
--
2.7.4
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Deucher, Alexander
Acked-by Alex DeucherQuoted 27 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Xiangliang Yu
Sent: Thursday, May 04, 2017 2:38 AM
To: [email protected]
Cc: Yu, Xiangliang; Min, Frank
Subject: [PATCH 6/6] drm/amdgpu: clean doorbell after sending init table to mmschFrom: Frank Min <[email protected]>
According to HW design, need to clean doorbell after setup MMSCH table.
Signed-off-by Frank Min <[email protected]>Signed-off-by Xiangliang Yu <[email protected]>--- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 1 + drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 1 + 2 files changed, 2 insertions(+)drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c +0
-0
drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c static int uvd_v7_0_mmsch_start(struct · line 701
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c +1
-0@@ -696,6 +696,7 @@ static int uvd_v7_0_mmsch_start(struct amdgpu_device *adev, dev_err(adev->dev, "failed to init MMSCH, mmVCE_MMSCH_VF_MAILBOX_RESP = %x\n", data); return -EBUSY; } +WDOORBELL32 (adev->uvd.ring_enc[0 ].doorbell_index,0 );
Just double checking, does VCE only use 32 bit doorbells? Gfx uses 64 bit doorbells. With that confirmed:
Quoted 21 lines
drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c +0
-0return 0 ;}
drivers/gpu/drm/amd/amdgpu/vce_v4_0.c +1
-0@@ -190,6 +190,7 @@ static int vce_v4_0_mmsch_start(struct amdgpu_device *adev, dev_err(adev->dev, "failed to init MMSCH, mmVCE_MMSCH_VF_MAILBOX_RESP = %x\n", data); return -EBUSY; } +WDOORBELL32 (adev->vce.ring[0 ].doorbell_index,0 );return 0;
}
--
2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx