Skip to contentSkip to conversation

driver core: platform: Add ability to find resource by name or index

PATCH In review Jon Mason 2 participants 3 messages May 8, 2017 – May 9, 2017

lore
Share & tools
lore

Jon Mason

author
#0 lore raw

PATCH 1/1 driver core: platform: Add ability to find resource by name or index

It is not always possible to find a resource via the name. This may be due to using previous versions of device tree without the names or using ACPI. To allow for resources to be discovered by either the name or the index, a wrapper was created. It attempts to find the resource via name, and if unable to find the resource, will then attempt to find the resource via index.

---
 include/linux/platform_device.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
include/linux/platform_device.h +15 -0
index 98c2a7c7108e..0f42e9cf96de 100644
@@ -59,6 +59,21 @@ extern struct resource *platform_get_resource_byname(struct platform_device *,
 extern int platform_get_irq_byname(struct platform_device *, const char *);
 extern int platform_add_devices(struct platform_device **, int);
 
+static inline struct resource *
+platform_get_resource_by_name_or_index(struct platform_device *dev,
+				       unsigned int type,
+				       const char *name,
+				       unsigned int num)
+{
+	struct resource *r;
+
+	r = platform_get_resource_byname(dev, type, name);
+	if (r)
+		return r;
+
+	return platform_get_resource(dev, type, num);
+}
+
 struct platform_device_info {
 		struct device *parent;
 		struct fwnode_handle *fwnode;
Signature · 1 line
2.7.4
#1 lore raw
Quoted 7 lines · Jon Mason

It is not always possible to find a resource via the name. This may be due to using previous versions of device tree without the names or using ACPI. To allow for resources to be discovered by either the name or the index, a wrapper was created. It attempts to find the resource via name, and if unable to find the resource, will then attempt to find the resource via index.

Quoted 5 lines
---
 include/linux/platform_device.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Do you have any users for this new function? We don't like adding apis without them...

thanks,

greg k-h

author
#2 lore raw
Quoted 8 lines · Greg Kroah-Hartman
Quoted 7 lines · Jon Mason

It is not always possible to find a resource via the name. This may be due to using previous versions of device tree without the names or using ACPI. To allow for resources to be discovered by either the name or the index, a wrapper was created. It attempts to find the resource via name, and if unable to find the resource, will then attempt to find the resource via index.

Quoted 8 lines
Quoted 5 lines
---
 include/linux/platform_device.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Do you have any users for this new function? We don't like adding apis without them...

That is fair. I currently only have one for an Ethernet device (as I am early in my ACPI enablement on this platform). There could possibly be more. So, I'll wait until I'm finished and push them as a series (unless you would prefer that I send what I have now and follow-on as I come across them).

Thanks,
Jon

Quoted 4 lines

thanks,

greg k-h