Skip to contentSkip to conversation

perf config: Bugfixes & Refactoring

PATCH Superseded Taeung Song 1 participant 1 message May 9, 2017

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v3 cover perf config: Bugfixes & Refactoring

Hi all,

This is simple patchset for perf-config
to fix small bugs and refactor code.

I'd appreciate some feedback on this patchset.

The code is also available at 'config/refactoring-v3' branch on

git://github.com/taeung/linux-perf.git

Thanks,
Taeung

v3:
- fix a bug of no checked 'ret' in the loop in cmd_config() (Arnaldo)
- modify commit log messages to be more clear (Aranaldo)
- return -1 if show_spec_config() cannot show the config
- initialize 'ret' with -1 instead of 0 for more compact code in cmd_config()
- Add a error message when perf_config_set__new() failed in cmd_config()

v2:
- there is no need to consider empty config file (Arnaldo)

Taeung Song (7):
perf config: Handle errors from {show_spec, set}_config() in the loop perf config: Refactor the code using 'ret' variable in cmd_config() perf config: Return -1 if show_spec_config() cannot show the config perf config: Add a error message when perf_config_set__new() failed in
cmd_config()
perf config: Finally write changed configs on config file at a time perf config: Check whether items are from system config in
set_config()
perf config: Support autogeneration of config file when setting
configs

 tools/perf/builtin-config.c | 57 +++++++++++++++++++++++++++++++--------------
 tools/perf/util/config.c    |  5 +---
 2 files changed, 40 insertions(+), 22 deletions(-)
Signature · 1 line
2.7.4