Staging: comedi: comedidev.h: fixed a warning
PATCH 1/1 Staging: comedi: comedidev.h: fixed a warning
Fixed a warning : struct comedi_lrange is generally constant.
--- drivers/staging/comedi/comedidev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/comedidev.h +1 -1
@@ -623,7 +623,7 @@ extern const struct comedi_lrange range_unknown;* There may also be a flag that indicates the minimum and maximum are merely * scale factors for an unknown, external reference. */ -struct comedi_lrange { +const struct comedi_lrange {int length;struct comedi_krange range[]; };
Signature · 1 line
2.7.4
Compile test your patches.
regards,
dan carpenter
Greg KH
maintainerQuoted 3 lines · srishti
Fixed a warning : struct
comedi_lrangeis generally constant.Signed-off-by Srishti Sharma <[email protected]>
As Dan pointed out, you _HAVE_ to test-build your changes.
Also, your "From:" line didn't match your signed-off-by line, so I couldn't accept this anyway.
thanks,
greg k-h
Quoted 5 lines · Greg KH
Quoted 3 lines · srishti
Fixed a warning : struct
comedi_lrangeis generally constant.Signed-off-by Srishti Sharma <[email protected]>
Quoted 8 lines
As Dan pointed out, you _HAVE_ to test-build your changes.
Also, your "From:" line didn't match your signed-off-by line, so I couldn't accept this anyway.
thanks,
greg k-h
Thanks for pointing out the error , but this patch is not needed as it was for fixing a warning produced by checkpatch.pl that says struct comedi_lrange is usually constant . But on building the code I get another warning which says that the type qualifier is useless.
Regards,
Srishti