Patch "orangefs: do not check possibly stale size on truncate" has been added to the 4.11-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
orangefs: do not check possibly stale size on truncate
to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
orangefs-do-not-check-possibly-stale-size-on-truncate.patch
and it can be found in the queue-4.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
53950ef541675df48c219a8d665111a0e68dfc2fMon Sep 17 00:00:00 2001
From: Martin Brandenburg <[email protected]>
Date: Tue, 25 Apr 2017 15:38:04 -0400
Subject: orangefs: do not check possibly stale size on truncate
From: Martin Brandenburg <[email protected]>
commit 53950ef541675df48c219a8d665111a0e68dfc2f upstream.
Let the server figure this out because our size might be out of date or not present.
The bug was that
xfs_io -f -t -c "pread -v 0 100" /mnt/foo echo "Test" > /mnt/foo xfs_io -f -t -c "pread -v 0 100" /mnt/foo
fails because the second truncate did not happen if nothing had requested the size after the write in echo. Thus i_size was zero (not present) and the orangefs_setattr though i_size was zero and there was nothing to do.
--- fs/orangefs/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
fs/orangefs/inode.c +1 -2
@@ -218,8 +218,7 @@ int orangefs_setattr(struct dentry *dentif (ret) goto out; -if ((iattr->ia_valid &ATTR_SIZE ) && - iattr->ia_size !=i_size_read (inode)) { +if (iattr->ia_valid &ATTR_SIZE ) { ret =orangefs_setattr_size (inode, iattr);if (ret) goto out;
Patches currently in stable-queue which might be from [email protected] are
queue-4.11/orangefs-do-not-check-possibly-stale-size-on-truncate.patch queue-4.11/orangefs-fix-bounds-check-for-listxattr.patch queue-4.11/orangefs-clean-up-oversize-xattr-validation.patch queue-4.11/orangefs-do-not-set-getattr_time-on-orangefs_lookup.patch