Skip to contentSkip to conversation

Patch "Bluetooth: hci_bcm: add missing tty-device sanity check" has been added to the 4.10-stable tree

PATCH [email protected] 1 participant 1 message May 18, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Bluetooth: hci_bcm: add missing tty-device sanity check

to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
bluetooth-hci_bcm-add-missing-tty-device-sanity-check.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 95065a61e9bf25fb85295127fba893200c2bbbd8 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Wed, 29 Mar 2017 18:15:27 +0200
Subject: Bluetooth: hci_bcm: add missing tty-device sanity check

From: Johan Hovold <[email protected]>

commit 95065a61e9bf25fb85295127fba893200c2bbbd8 upstream.

Make sure to check the tty-device pointer before looking up the sibling platform device to avoid dereferencing a NULL-pointer when the tty is one end of a Unix98 pty.

Fixes 0395ffc1ee05 ("Bluetooth: hci_bcm: Add PM for BCM devices")
Cc Frederic Danis <[email protected]>
---
 drivers/bluetooth/hci_bcm.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/bluetooth/hci_bcm.c +4 -1
@@ -287,6 +287,9 @@ static int bcm_open(struct hci_uart *hu)
 
 	hu->priv = bcm;
 
+	if (!hu->tty->dev)
+		goto out;
+
 	mutex_lock(&bcm_device_lock);
 	list_for_each(p, &bcm_device_list) {
 		struct bcm_device *dev = list_entry(p, struct bcm_device, list);
@@ -307,7 +310,7 @@ static int bcm_open(struct hci_uart *hu)
 	}
 
 	mutex_unlock(&bcm_device_lock);
-
+out:
 	return 0;
 }
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.10/usb-serial-ftdi_sio-add-device-id-for-microsemi-arrow-sf2plus-dev-kit.patch queue-4.10/bluetooth-hci_bcm-add-missing-tty-device-sanity-check.patch queue-4.10/bluetooth-hci_intel-add-missing-tty-device-sanity-check.patch queue-4.10/serial-omap-fix-runtime-pm-handling-on-unbind.patch queue-4.10/serial-omap-suspend-device-on-probe-errors.patch queue-4.10/staging-gdm724x-gdm_mux-fix-use-after-free-on-module-unload.patch