Patch "ipmi: Fix kernel panic at ipmi_ssif_thread()" has been added to the 4.4-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ipmi: Fix kernel panic at ipmi_ssif_thread()
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ipmi-fix-kernel-panic-at-ipmi_ssif_thread.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
6de65fcfdb51835789b245203d1bfc8d14cb1e06Mon Sep 17 00:00:00 2001
From: Joeseph Chang <[email protected]>
Date: Mon, 27 Mar 2017 20:22:09 -0600
Subject: ipmi: Fix kernel panic at ipmi_ssif_thread()
From: Joeseph Chang <[email protected]>
commit 6de65fcfdb51835789b245203d1bfc8d14cb1e06 upstream.
msg_written_handler() may set ssif_info->multi_data to NULL when using ipmitool to write fru.
Before setting ssif_info->multi_data to NULL, add new local pointer "data_to_send" and store correct i2c data pointer to it to fix NULL pointer kernel panic and incorrect ssif_info->multi_pos.
--- drivers/char/ipmi/ipmi_ssif.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/char/ipmi/ipmi_ssif.c +3 -1
@@ -888,6 +888,7 @@ static void msg_written_handler(struct s* for details on the intricacies of this. */ int left; +unsigned char *data_to_send;ssif_inc_stat (ssif_info, sent_messages_parts);
@@ -896,6 +897,7 @@ static void msg_written_handler(struct s left =32 ;/* Length byte. */ ssif_info->multi_data[ssif_info->multi_pos] = left; + data_to_send = ssif_info->multi_data + ssif_info->multi_pos; ssif_info->multi_pos += left;if (left <32 )/*
@@ -909,7 +911,7 @@ static void msg_written_handler(struct s rv =ssif_i2c_send (ssif_info, msg_written_handler,I2C_SMBUS_WRITE ,SSIF_IPMI_MULTI_PART_REQUEST_MIDDLE , - ssif_info->multi_data + ssif_info->multi_pos, + data_to_send,I2C_SMBUS_BLOCK_DATA );if (rv <0 ) {/* request failed, just return the error. */
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/ipmi-fix-kernel-panic-at-ipmi_ssif_thread.patch