Skip to contentSkip to conversation

Patch "of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message May 22, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
of-fix-cpus-reference-leak-in-of_numa_parse_cpu_nodes.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b8475cbee5ab2eac05f9cd5dbcc94c453d3cbf10 Mon Sep 17 00:00:00 2001

From: Tyrel Datwyler <[email protected]>
Date: Mon, 17 Apr 2017 20:29:17 -0400
Subject: of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()

From: Tyrel Datwyler <[email protected]>

commit b8475cbee5ab2eac05f9cd5dbcc94c453d3cbf10 upstream.

The call to of_find_node_by_path("/cpus") returns the cpus device_node with its reference count incremented. There is no matching of_node_put() call in of_numa_parse_cpu_nodes() which results in a leaked reference to the "/cpus" node.

This patch adds an of_node_put() to release the reference.

Fixes 298535c00a2c ("of, numa: Add NUMA of binding implementation.")
---
 drivers/of/of_numa.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/of/of_numa.c +2 -0
@@ -57,6 +57,8 @@ static void __init of_numa_parse_cpu_nod
 		else
 			node_set(nid, numa_nodes_parsed);
 	}
+
+	of_node_put(cpus);
 }
 
 static int __init of_numa_parse_memory_nodes(void)

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/of-fix-cpus-reference-leak-in-of_numa_parse_cpu_nodes.patch