Skip to contentSkip to conversation

Patch "USB: chaoskey: fix Alea quirk on big-endian hosts" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message May 22, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

USB: chaoskey: fix Alea quirk on big-endian hosts

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-chaoskey-fix-alea-quirk-on-big-endian-hosts.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 63afd5cc78775018ea2dec4004428dafa5283e93 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Thu, 11 May 2017 11:36:01 +0200
Subject: USB: chaoskey: fix Alea quirk on big-endian hosts

From: Johan Hovold <[email protected]>

commit 63afd5cc78775018ea2dec4004428dafa5283e93 upstream.

Add missing endianness conversion when applying the Alea timeout quirk.

Found using sparse:

warning: restricted __le16 degrades to integer

Fixes e4a886e811cd ("hwrng: chaoskey - Fix URB warning due to timeout on Alea")
Cc Bob Ham <[email protected]>
Cc Herbert Xu <[email protected]>
Cc Keith Packard <[email protected]>
---
 drivers/usb/misc/chaoskey.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/misc/chaoskey.c +1 -1
@@ -194,7 +194,7 @@ static int chaoskey_probe(struct usb_int
 
 	dev->in_ep = in_ep;
 
-	if (udev->descriptor.idVendor != ALEA_VENDOR_ID)
+	if (le16_to_cpu(udev->descriptor.idVendor) != ALEA_VENDOR_ID)
 		dev->reads_started = 1;
 
 	dev->size = size;

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/usb-chaoskey-fix-alea-quirk-on-big-endian-hosts.patch queue-4.9/usb-serial-ftdi_sio-add-olimex-arm-usb-tiny-h-pids.patch queue-4.9/usb-serial-ftdi_sio-fix-setting-latency-for-unprivileged-users.patch queue-4.9/watchdog-pcwd_usb-fix-null-deref-at-probe.patch queue-4.9/of-fdt-add-missing-allocation-failure-check.patch queue-4.9/ath9k_htc-fix-null-deref-at-probe.patch