Skip to contentSkip to conversation

FAILED: patch "[PATCH] [media] digitv: limit messages to buffer size" failed to apply to 4.4-stable tree

PATCH [email protected] 1 participant 1 message May 23, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 821117dc21083a99dd99174c10848d70ff43de29 Mon Sep 17 00:00:00 2001

From: Alyssa Milburn <[email protected]>
Date: Sat, 1 Apr 2017 14:33:42 -0300
Subject: [PATCH] [media] digitv: limit messages to buffer size

Return an error rather than memcpy()ing beyond the end of the buffer. Internal callers use appropriate sizes, but digitv_i2c_xfer may not.

drivers/media/usb/dvb-usb/digitv.c +3 -0
index 4284f6984dc1..475a3c0cdee7 100644
@@ -33,6 +33,9 @@ static int digitv_ctrl_msg(struct dvb_usb_device *d,
 
 	wo = (rbuf == NULL || rlen == 0); /* write-only */
 
+	if (wlen > 4 || rlen > 4)
+		return -EIO;
+
 	memset(st->sndbuf, 0, 7);
 	memset(st->rcvbuf, 0, 7);