Skip to contentSkip to conversation

ASoC: cs4271: Remove unnecessary additional variable definition

PATCH In review Charles Keepax 3 participants 3 messages May 23, 2017 – May 24, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: cs4271: Remove unnecessary additional variable definition

The function already defines a ret variable at the top and makes no particular use of the shadowed definition, as such remove the redundant definition.

---
 sound/soc/codecs/cs4271.c | 2 --
 1 file changed, 2 deletions(-)
sound/soc/codecs/cs4271.c +0 -2
index e78b5f0..d882477 100644
@@ -674,8 +674,6 @@ static int cs4271_common_probe(struct device *dev,
 		cs4271->gpio_nreset = cs4271plat->gpio_nreset;
 
 	if (gpio_is_valid(cs4271->gpio_nreset)) {
-		int ret;
-
 		ret = devm_gpio_request(dev, cs4271->gpio_nreset,
 					"CS4271 Reset");
 		if (ret < 0)
Signature · 1 line
2.1.4
Acked-by on v1 1/1
#1 lore raw

Re: [PATCH] ASoC: cs4271: Remove unnecessary additional variable definitio

Quoted 15 lines · Charles Keepax

The function already defines a ret variable at the top and makes no particular use of the shadowed definition, as such remove the redundant definition.

---
 sound/soc/codecs/cs4271.c | 2 --
 1 file changed, 2 deletions(-)
sound/soc/codecs/cs4271.c +0 -0
index e78b5f0..d882477 100644

sound/soc/codecs/cs4271.c static int cs4271_common_probe(struct device *dev, · line 679

Quoted 8 lines
sound/soc/codecs/cs4271.c +0 -2
@@ -674,8 +674,6 @@ static int cs4271_common_probe(struct device *dev,
 		cs4271->gpio_nreset = cs4271plat->gpio_nreset;
 
 	if (gpio_is_valid(cs4271->gpio_nreset)) {
-		int ret;
-
 		ret = devm_gpio_request(dev, cs4271->gpio_nreset,
 					"CS4271 Reset");
 		if (ret < 0)
maintainer
#2 lore raw

Applied "ASoC: cs4271: Remove unnecessary additional variable definition" to the asoc tree

In reply to Charles Keepax

The patch

ASoC: cs4271: Remove unnecessary additional variable definition

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 177e27133ae9c9f5cbc306feaaa53d8fbc75e45f Mon Sep 17 00:00:00 2001

From: Charles Keepax <[email protected]>
Date: Tue, 23 May 2017 16:03:39 +0100
Subject: [PATCH] ASoC: cs4271: Remove unnecessary additional variable
definition

The function already defines a ret variable at the top and makes no particular use of the shadowed definition, as such remove the redundant definition.

---
 sound/soc/codecs/cs4271.c | 2 --
 1 file changed, 2 deletions(-)
sound/soc/codecs/cs4271.c +0 -2
index e78b5f055f25..d8824773dc29 100644
@@ -674,8 +674,6 @@ static int cs4271_common_probe(struct device *dev,
 		cs4271->gpio_nreset = cs4271plat->gpio_nreset;
 
 	if (gpio_is_valid(cs4271->gpio_nreset)) {
-		int ret;
-
 		ret = devm_gpio_request(dev, cs4271->gpio_nreset,
 					"CS4271 Reset");
 		if (ret < 0)
Signature · 1 line
2.11.0