Skip to contentSkip to conversation

sunxi: sinovoip: Use proper naming convention for BPI boards

PATCH New Jagan Teki 3 participants 4 messages May 29, 2017 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH 1/1 sunxi: sinovoip: Use proper naming convention for BPI boards

From: Jagan Teki <[email protected]>

- Rename Sinovoip BPI defconfigs to use small letter
- To avoid naming conflict with 'LeMaker' add sinovoip prefix to BPI M2 Ultra defconfig since bananapi is also name used by 'LeMaker'
- Add 'SINOVOIP' prefix 'BANANAPI M2 ULTRA BOARD' under board/sunxi/MAINTAINERS file.

Cc Icenowy Zheng <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc VishnuPatekar <[email protected]>
---
 board/sunxi/MAINTAINERS                                        | 10 +++++-----
 .../{Sinovoip_BPI_M2_defconfig => sinovoip_bpi_m2_defconfig}   |  0
 ...ip_BPI_M2_Plus_defconfig => sinovoip_bpi_m2_plus_defconfig} |  0
 ...napi_M2_Ultra_defconfig => sinovoip_bpi_m2_ultra_defconfig} |  0
 .../{Sinovoip_BPI_M3_defconfig => sinovoip_bpi_m3_defconfig}   |  0
 5 files changed, 5 insertions(+), 5 deletions(-)
 rename configs/{Sinovoip_BPI_M2_defconfig => sinovoip_bpi_m2_defconfig} (100%)
 rename configs/{Sinovoip_BPI_M2_Plus_defconfig => sinovoip_bpi_m2_plus_defconfig} (100%)
 rename configs/{Bananapi_M2_Ultra_defconfig => sinovoip_bpi_m2_ultra_defconfig} (100%)
 rename configs/{Sinovoip_BPI_M3_defconfig => sinovoip_bpi_m3_defconfig} (100%)
board/sunxi/MAINTAINERS +5 -5
index a512a20..61d1479 100644
@@ -41,7 +41,7 @@ F:	configs/CSQ_CS908_defconfig
 F:	configs/inet_q972_defconfig
 F:	configs/Mele_A1000G_quad_defconfig
 F:	configs/Mele_M9_defconfig
-F:	configs/Sinovoip_BPI_M2_defconfig
+F:	configs/sinovoip_bpi_m2_defconfig
 F:	include/configs/sun7i.h
 F:	configs/A20-OLinuXino_MICRO_defconfig
 F:	configs/Bananapi_defconfig
@@ -108,10 +108,10 @@ M:	Paul Kocialkowski <[email protected]>
 S:	Maintained
 F:	configs/Ampe_A76_defconfig
 
-BANANAPI M2 ULTRA BOARD
+SINOVOIP BANANAPI M2 ULTRA BOARD
 M:	Chen-Yu Tsai <[email protected]>
 S:	Maintained
-F:	configs/Bananapi_M2_Ultra_defconfig
+F:	configs/sinovoip_bpi_m2_ultra_defconfig
 F:	arch/arm/dts/sun8i-r40-bananapi-m2-ultra.dts
 
 COLOMBUS BOARD
@@ -287,12 +287,12 @@ W:	http://linux-sunxi.org/Sinlinx_SinA33
 SINOVOIP BPI M2 PLUS H3 BOARD
 M:	Icenowy Zheng <[email protected]>
 S:	Maintained
-F:	configs/Sinovoip_BPI_M2_Plus_defconfig
+F:	configs/sinovoip_bpi_m2_Plus_defconfig
 
 SINOVOIP BPI M3 A83T BOARD
 M:	VishnuPatekar <[email protected]>
 S:	Maintained
-F:	configs/Sinovoip_BPI_M3_defconfig
+F:	configs/sinovoip_bpi_m3_defconfig
 
 SUNCHIP CX-A99 BOARD
 M:	Rask Ingemann Lambertsen <[email protected]>
configs/sinovoip_bpi_m2_defconfig renamed from configs/Sinovoip_BPI_M2_defconfig +0 -0
similarity index 100%
rename from configs/Sinovoip_BPI_M2_defconfig
rename to configs/sinovoip_bpi_m2_defconfig
configs/sinovoip_bpi_m2_plus_defconfig renamed from configs/Sinovoip_BPI_M2_Plus_defconfig +0 -0
similarity index 100%
rename from configs/Sinovoip_BPI_M2_Plus_defconfig
rename to configs/sinovoip_bpi_m2_plus_defconfig
configs/sinovoip_bpi_m2_ultra_defconfig renamed from configs/Bananapi_M2_Ultra_defconfig +0 -0
similarity index 100%
rename from configs/Bananapi_M2_Ultra_defconfig
rename to configs/sinovoip_bpi_m2_ultra_defconfig
configs/sinovoip_bpi_m3_defconfig renamed from configs/Sinovoip_BPI_M3_defconfig +0 -0
similarity index 100%
rename from configs/Sinovoip_BPI_M3_defconfig
rename to configs/sinovoip_bpi_m3_defconfig
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 sunxi: sinovoip: Use proper naming convention for BPI boards

Quoted 8 lines · Jagan Teki

From: Jagan Teki <[email protected]>

- Rename Sinovoip BPI defconfigs to use small letter
- To avoid naming conflict with 'LeMaker' add sinovoip prefix to BPI M2 Ultra defconfig since bananapi is also name used by 'LeMaker'
- Add 'SINOVOIP' prefix 'BANANAPI M2 ULTRA BOARD' under board/sunxi/MAINTAINERS file.

No. The proper solution is to just get rid of the Sinovoip and LeMaker bullshit. The brand name has been and will continue to be "Banana Pi". Apart from the trademark legal drama between LeMaker, Sinovoip, and Foxconn, the boards are now consistently named "BPI-xyz". The original "Banana Pi" is now the "BPI-M1". The only incompatible outlier is the LeMaker made BananaPro.

LeMaker and Sinovoip are distributors. Maybe they manufacture(d) as well, but I'm not so sure.

Also, see https://www.spinics.net/lists/devicetree/msg176001.html

Note that "BIPAI KEJI LIMITED" is just a translation for BPI Technologies limited. BIPAI is the phonetics for B-PI in English. KEJI is the phonetics for "technology" in Chinese.

Finally, is there a preference for all lowercase defconfig file names?

Regards
ChenYu

Quoted 76 lines
Cc Icenowy Zheng <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc VishnuPatekar <[email protected]>
---
 board/sunxi/MAINTAINERS                                        | 10 +++++-----
 .../{Sinovoip_BPI_M2_defconfig => sinovoip_bpi_m2_defconfig}   |  0
 ...ip_BPI_M2_Plus_defconfig => sinovoip_bpi_m2_plus_defconfig} |  0
 ...napi_M2_Ultra_defconfig => sinovoip_bpi_m2_ultra_defconfig} |  0
 .../{Sinovoip_BPI_M3_defconfig => sinovoip_bpi_m3_defconfig}   |  0
 5 files changed, 5 insertions(+), 5 deletions(-)
 rename configs/{Sinovoip_BPI_M2_defconfig => sinovoip_bpi_m2_defconfig} (100%)
 rename configs/{Sinovoip_BPI_M2_Plus_defconfig => sinovoip_bpi_m2_plus_defconfig} (100%)
 rename configs/{Bananapi_M2_Ultra_defconfig => sinovoip_bpi_m2_ultra_defconfig} (100%)
 rename configs/{Sinovoip_BPI_M3_defconfig => sinovoip_bpi_m3_defconfig} (100%)
board/sunxi/MAINTAINERS +5 -5
index a512a20..61d1479 100644
@@ -41,7 +41,7 @@ F:    configs/CSQ_CS908_defconfig
 F:     configs/inet_q972_defconfig
 F:     configs/Mele_A1000G_quad_defconfig
 F:     configs/Mele_M9_defconfig
-F:     configs/Sinovoip_BPI_M2_defconfig
+F:     configs/sinovoip_bpi_m2_defconfig
 F:     include/configs/sun7i.h
 F:     configs/A20-OLinuXino_MICRO_defconfig
 F:     configs/Bananapi_defconfig
@@ -108,10 +108,10 @@ M:        Paul Kocialkowski <[email protected]>
 S:     Maintained
 F:     configs/Ampe_A76_defconfig
 
-BANANAPI M2 ULTRA BOARD
+SINOVOIP BANANAPI M2 ULTRA BOARD
 M:     Chen-Yu Tsai <[email protected]>
 S:     Maintained
-F:     configs/Bananapi_M2_Ultra_defconfig
+F:     configs/sinovoip_bpi_m2_ultra_defconfig
 F:     arch/arm/dts/sun8i-r40-bananapi-m2-ultra.dts
 
 COLOMBUS BOARD
@@ -287,12 +287,12 @@ W:        http://linux-sunxi.org/Sinlinx_SinA33
 SINOVOIP BPI M2 PLUS H3 BOARD
 M:     Icenowy Zheng <[email protected]>
 S:     Maintained
-F:     configs/Sinovoip_BPI_M2_Plus_defconfig
+F:     configs/sinovoip_bpi_m2_Plus_defconfig
 
 SINOVOIP BPI M3 A83T BOARD
 M:     VishnuPatekar <[email protected]>
 S:     Maintained
-F:     configs/Sinovoip_BPI_M3_defconfig
+F:     configs/sinovoip_bpi_m3_defconfig
 
 SUNCHIP CX-A99 BOARD
 M:     Rask Ingemann Lambertsen <[email protected]>
configs/sinovoip_bpi_m2_defconfig renamed from configs/Sinovoip_BPI_M2_defconfig +0 -0
similarity index 100%
rename from configs/Sinovoip_BPI_M2_defconfig
rename to configs/sinovoip_bpi_m2_defconfig
configs/sinovoip_bpi_m2_plus_defconfig renamed from configs/Sinovoip_BPI_M2_Plus_defconfig +0 -0
similarity index 100%
rename from configs/Sinovoip_BPI_M2_Plus_defconfig
rename to configs/sinovoip_bpi_m2_plus_defconfig
configs/sinovoip_bpi_m2_ultra_defconfig renamed from configs/Bananapi_M2_Ultra_defconfig +0 -0
similarity index 100%
rename from configs/Bananapi_M2_Ultra_defconfig
rename to configs/sinovoip_bpi_m2_ultra_defconfig
configs/sinovoip_bpi_m3_defconfig renamed from configs/Sinovoip_BPI_M3_defconfig +0 -1
similarity index 100%
rename from configs/Sinovoip_BPI_M3_defconfig
rename to configs/sinovoip_bpi_m3_defconfig
--

1.9.1

#2 lore raw

PATCH 1/1 sunxi: sinovoip: Use proper naming convention for BPI boards

Quoted 10 lines · Chen-Yu Tsai
Quoted 8 lines · Jagan Teki

From: Jagan Teki <[email protected]>

- Rename Sinovoip BPI defconfigs to use small letter
- To avoid naming conflict with 'LeMaker' add sinovoip prefix to BPI M2 Ultra defconfig since bananapi is also name used by 'LeMaker'
- Add 'SINOVOIP' prefix 'BANANAPI M2 ULTRA BOARD' under board/sunxi/MAINTAINERS file.

Quoted 6 lines

No. The proper solution is to just get rid of the Sinovoip and LeMaker bullshit. The brand name has been and will continue to be "Banana Pi". Apart from the trademark legal drama between LeMaker, Sinovoip, and Foxconn, the boards are now consistently named "BPI-xyz". The original "Banana Pi" is now the "BPI-M1". The only incompatible outlier is the LeMaker made BananaPro.

But there is one board Bananapi_defconfig which is from LeMaker, which will conflict if we skip these and use binanapi for rest.

Quoted 9 lines

LeMaker and Sinovoip are distributors. Maybe they manufacture(d) as well, but I'm not so sure.

Also, see https://www.spinics.net/lists/devicetree/msg176001.html

Note that "BIPAI KEJI LIMITED" is just a translation for BPI Technologies limited. BIPAI is the phonetics for B-PI in English. KEJI is the phonetics for "technology" in Chinese.

Thanks for the info.

Quoted 2 lines

Finally, is there a preference for all lowercase defconfig file names?

Yes, for newly supported and/or longer stable defconfigs/boards follow lower-case defconfig file names in U-Boot.

thanks!

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
#3 lore raw

PATCH 1/1 sunxi: sinovoip: Use proper naming convention for BPI boards

Quoted 18 lines · Jagan Teki
Quoted 10 lines · Chen-Yu Tsai
Quoted 8 lines · Jagan Teki

From: Jagan Teki <[email protected]>

- Rename Sinovoip BPI defconfigs to use small letter
- To avoid naming conflict with 'LeMaker' add sinovoip prefix to BPI M2 Ultra defconfig since bananapi is also name used by 'LeMaker'
- Add 'SINOVOIP' prefix 'BANANAPI M2 ULTRA BOARD' under board/sunxi/MAINTAINERS file.

Quoted 6 lines

No. The proper solution is to just get rid of the Sinovoip and LeMaker bullshit. The brand name has been and will continue to be "Banana Pi". Apart from the trademark legal drama between LeMaker, Sinovoip, and Foxconn, the boards are now consistently named "BPI-xyz". The original "Banana Pi" is now the "BPI-M1". The only incompatible outlier is the LeMaker made BananaPro.

Quoted 2 lines

But there is one board Bananapi_defconfig which is from LeMaker, which will conflict if we skip these and use binanapi for rest.

There's nothing that conflicts. Just like for the Cubieboards, Bananapi serves as the prefix. So the defconfigs would be named:

- Bananapi_defconfig (or Bananapi_M1_defconfig if you prefer)
- Bananapi_M1_Plus_defconfig
- Bananapi_M2_defconfig

and the list goes on.

Quoted 10 lines
Quoted 9 lines

LeMaker and Sinovoip are distributors. Maybe they manufacture(d) as well, but I'm not so sure.

Also, see https://www.spinics.net/lists/devicetree/msg176001.html

Note that "BIPAI KEJI LIMITED" is just a translation for BPI Technologies limited. BIPAI is the phonetics for B-PI in English. KEJI is the phonetics for "technology" in Chinese.

Quoted 7 lines

Thanks for the info.

Quoted 2 lines

Finally, is there a preference for all lowercase defconfig file names?

Yes, for newly supported and/or longer stable defconfigs/boards follow lower-case defconfig file names in U-Boot.

I see. Thanks!

ChenYu