Patch "geneve: fix fill_info when using collect_metadata" has been added to the 4.11-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
geneve: fix fill_info when using collect_metadata
to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
geneve-fix-fill_info-when-using-collect_metadata.patch
and it can be found in the queue-4.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Wed May 31 09:13:10 JST 2017
From: Eric Garver <[email protected]>
Date: Tue, 23 May 2017 18:37:27 -0400
Subject: geneve: fix fill_info when using collect_metadata
From: Eric Garver <[email protected]>
[ Upstream commit 11387fe4a98f75d1f4cdb3efe3b42b19205c9df5 ]
Since 9b4437a5b870 ("geneve: Unify LWT and netdev handling.") fill_info does not return UDP_ZERO_CSUM6_RX when using COLLECT_METADATA. This is because it uses ip_tunnel_info_af() with the device level info, which is not valid for COLLECT_METADATA.
Fix by checking for the presence of the actual sockets.
--- drivers/net/geneve.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/net/geneve.c +5 -3
@@ -1293,7 +1293,7 @@ static int geneve_fill_info(struct sk_buif (nla_put_u32 (skb,IFLA_GENEVE_ID , vni)) goto nla_put_failure; -if (ip_tunnel_info_af (info) ==AF_INET ) { +if (rtnl_dereference (geneve->sock4)) {if (nla_put_in_addr (skb,IFLA_GENEVE_REMOTE , info->key.u.ipv4.dst)) goto nla_put_failure;
@@ -1302,8 +1302,10 @@ static int geneve_fill_info(struct sk_bu !!(info->key.tun_flags & TUNNEL_CSUM))) goto nla_put_failure; + } +#if IS_ENABLED (CONFIG_IPV6 ) - } else { +if (rtnl_dereference (geneve->sock6)) {if (nla_put_in6_addr (skb,IFLA_GENEVE_REMOTE6 , &info->key.u.ipv6.dst)) goto nla_put_failure;
@@ -1315,8 +1317,8 @@ static int geneve_fill_info(struct sk_buif (nla_put_u8 (skb,IFLA_GENEVE_UDP_ZERO_CSUM6_RX , !geneve->use_udp6_rx_checksums)) goto nla_put_failure; -#endif } +#endif if (nla_put_u8(skb, IFLA_GENEVE_TTL, info->key.ttl) || nla_put_u8(skb, IFLA_GENEVE_TOS, info->key.tos) ||
Patches currently in stable-queue which might be from [email protected] are
queue-4.11/geneve-fix-fill_info-when-using-collect_metadata.patch