Patch "s390/qeth: avoid null pointer dereference on OSN" has been added to the 3.18-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
s390/qeth: avoid null pointer dereference on OSN
to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
s390-qeth-avoid-null-pointer-dereference-on-osn.patch
and it can be found in the queue-3.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Fri Jun 2 12:04:25 JST 2017
From: Julian Wiedmann <[email protected]>
Date: Wed, 10 May 2017 19:07:53 +0200
Subject: s390/qeth: avoid null pointer dereference on OSN
From: Julian Wiedmann <[email protected]>
[ Upstream commit 25e2c341e7818a394da9abc403716278ee646014 ]
Access card->dev only after checking whether's its valid.
--- drivers/s390/net/qeth_l2_main.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/s390/net/qeth_l2_main.c +6 -4
@@ -970,7 +970,6 @@ static int qeth_l2_setup_netdev(struct qcase QETH_CARD_TYPE_OSN : card->dev =alloc_netdev (0 ,"osn%d" ,NET_NAME_UNKNOWN , ether_setup); - card->dev->flags |=IFF_NOARP ;break ;default : card->dev =alloc_etherdev (0 );
@@ -983,9 +982,12 @@ static int qeth_l2_setup_netdev(struct q card->dev->watchdog_timeo =QETH_TX_TIMEOUT ; card->dev->mtu = card->info.initial_mtu; card->dev->netdev_ops = &qeth_l2_netdev_ops; - card->dev->ethtool_ops = - (card->info.type !=QETH_CARD_TYPE_OSN ) ? - &qeth_l2_ethtool_ops : &qeth_l2_osn_ops; +if (card->info.type ==QETH_CARD_TYPE_OSN ) { + card->dev->ethtool_ops = &qeth_l2_osn_ops; + card->dev->flags |=IFF_NOARP ; + }else { + card->dev->ethtool_ops = &qeth_l2_ethtool_ops; + } card->dev->features |=NETIF_F_HW_VLAN_CTAG_FILTER ; card->info.broadcast_capable =1 ;qeth_l2_request_initial_mac (card);
Patches currently in stable-queue which might be from [email protected] are
queue-3.18/s390-qeth-avoid-null-pointer-dereference-on-osn.patch queue-3.18/s390-qeth-unbreak-osm-and-osn-support.patch queue-3.18/s390-qeth-handle-sysfs-error-during-initialization.patch