Skip to contentSkip to conversation

Fix: use LDFLAGS instead of LIBS for python bindings

PATCH Jérémie Galarneau 1 participant 1 message Jun 13, 2017 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Merged in stable-1.5. Thanks!

Jérémie

Quoted 25 lines · Michael Jeanson

Turns out that contrary to what is documented some versions of distutils don't honor the LIBS variable, use LDFLAGS instead.

---
 bindings/python/Makefile.am | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
bindings/python/Makefile.am +1 -3
index f6806a8..2ceab03 100644
@@ -25,8 +25,7 @@ BINDINGS_DEPS=setup.py \
 BUILD_FLAGS=CC="$(CC)" \
                CFLAGS="$(GLIB_CFLAGS) $(AM_CFLAGS) $(CFLAGS)" \
                CPPFLAGS="$(DEFS) $(DEFAULT_INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS)" \
-               LDFLAGS="$(AM_LDFLAGS) $(LDFLAGS)" \
-               LIBS="$(GLIB_LIBS) $(LIBS)"
+               LDFLAGS="$(AM_LDFLAGS) $(LDFLAGS) $(GLIB_LIBS) $(LIBS)"
 
 build-python-bindings.stamp: $(BINDINGS_DEPS)
        $(BUILD_FLAGS) $(PYTHON) $(builddir)/setup.py build_ext
--

2.7.4

Signature · 7 lines
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev