patch "mei: make sysfs modalias format similar as uevent modalias" added to char-misc-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
mei: make sysfs modalias format similar as uevent modalias
to my char-misc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
6f9193ec044a8f72d8b6ae94a5c4ab6e8b0f00caMon Sep 17 00:00:00 2001
From: Pratyush Anand <[email protected]>
Date: Mon, 29 May 2017 22:08:24 +0300
Subject: mei: make sysfs modalias format similar as uevent modalias
modprobe is not able to resolve sysfs modalias for mei devices.
# cat /sys/class/watchdog/watchdog0/device/watchdog/watchdog0/device/modalias mei::05b79a6f-4628-4d7f-899d-a91514cb32ab: # modprobe --set-version 4.9.6-200.fc25.x86_64 -R mei::05b79a6f-4628-4d7f-899d-a91514cb32ab: modprobe: FATAL: Module mei::05b79a6f-4628-4d7f-899d-a91514cb32ab: not found in directory /lib/modules/4.9.6-200.fc25.x86_64 # cat /lib/modules/4.9.6-200.fc25.x86_64/modules.alias | grep 05b79a6f-4628-4d7f-899d-a91514cb32ab alias mei:*:05b79a6f-4628-4d7f-899d-a91514cb32ab:*:* mei_wdt
commit b26864cad1c9 ("mei: bus: add client protocol version to the device alias"), however sysfs modalias is still in formmat mei:S:uuid:*.
This patch equates format of uevent and sysfs modalias so that modprobe is able to resolve the aliases.
--- drivers/misc/mei/bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/misc/mei/bus.c +3 -1
@@ -763,8 +763,10 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *a, {struct mei_cl_device *cldev =to_mei_cl_device (dev);const uuid_le *uuid =mei_me_cl_uuid (cldev->me_cl); +u8 version =mei_me_cl_ver (cldev->me_cl); -return scnprintf (buf,PAGE_SIZE ,"mei:%s:%pUl:" , cldev->name, uuid); +return scnprintf (buf,PAGE_SIZE ,"mei:%s:%pUl:%02X:" , + cldev->name, uuid, version); }static DEVICE_ATTR_RO (modalias);
Signature · 1 line
2.13.0