Skip to contentSkip to conversation

Patch "ibmvscsis: Clear left-over abort_cmd pointers" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jun 5, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ibmvscsis: Clear left-over abort_cmd pointers

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ibmvscsis-clear-left-over-abort_cmd-pointers.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 98883f1b5415ea9dce60d5178877d15f4faa10b8 Mon Sep 17 00:00:00 2001

From: "Bryant G. Ly" <[email protected]>
Date: Tue, 9 May 2017 11:50:26 -0500
Subject: ibmvscsis: Clear left-over abort_cmd pointers

From: Bryant G. Ly <[email protected]>

commit 98883f1b5415ea9dce60d5178877d15f4faa10b8 upstream.

With the addition of ibmvscsis->abort_cmd pointer within commit 25e78531268e ("ibmvscsis: Do not send aborted task response"), make sure to explicitly NULL these pointers when clearing DELAY_SEND flag.

Do this for two cases, when getting the new new ibmvscsis descriptor in ibmvscsis_get_free_cmd() and before posting the response completion in ibmvscsis_send_messages().

---
 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c +3 -0
@@ -1170,6 +1170,8 @@ static struct ibmvscsis_cmd *ibmvscsis_g
 		cmd = list_first_entry_or_null(&vscsi->free_cmd,
 					       struct ibmvscsis_cmd, list);
 		if (cmd) {
+			if (cmd->abort_cmd)
+				cmd->abort_cmd = NULL;
 			cmd->flags &= ~(DELAY_SEND);
 			list_del(&cmd->list);
 			cmd->iue = iue;
@@ -1774,6 +1776,7 @@ static void ibmvscsis_send_messages(stru
 				if (cmd->abort_cmd) {
 					retry = true;
 					cmd->abort_cmd->flags &= ~(DELAY_SEND);
+					cmd->abort_cmd = NULL;
 				}
 
 				/*

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/ibmvscsis-fix-the-incorrect-req_lim_delta.patch queue-4.11/ibmvscsis-clear-left-over-abort_cmd-pointers.patch