Skip to contentSkip to conversation

Patch "RDMA/srp: Fix NULL deref at srp_destroy_qp()" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jun 5, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

RDMA/srp: Fix NULL deref at srp_destroy_qp()

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
rdma-srp-fix-null-deref-at-srp_destroy_qp.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 95c2ef50c726a51d580c35ae8dccd383abaa8701 Mon Sep 17 00:00:00 2001

From: Israel Rukshin <[email protected]>
Date: Thu, 11 May 2017 18:52:36 +0300
Subject: RDMA/srp: Fix NULL deref at srp_destroy_qp()

From: Israel Rukshin <[email protected]>

commit 95c2ef50c726a51d580c35ae8dccd383abaa8701 upstream.

If srp_init_qp() fails at srp_create_ch_ib() then ch->send_cq may be NULL.
Calling directly to ib_destroy_qp() is sufficient because no work requests were posted on the created qp.

Fixes 9294000d6d89 ("IB/srp: Drain the send queue before destroying a QP")
---
 drivers/infiniband/ulp/srp/ib_srp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/ulp/srp/ib_srp.c +1 -1
@@ -570,7 +570,7 @@ static int srp_create_ch_ib(struct srp_r
 	return 0;
 
 err_qp:
-	srp_destroy_qp(ch, qp);
+	ib_destroy_qp(qp);
 
 err_send_cq:
 	ib_free_cq(send_cq);

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/rdma-srp-fix-null-deref-at-srp_destroy_qp.patch