Skip to contentSkip to conversation

ASoC: topology: Fix build by declaring snd_kcontrol_new and soc_dai_link.

PATCH In review Liam Girdwood 2 participants 2 messages Jun 6, 2017 – Jun 7, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ASoC: topology: Fix build by declaring snd_kcontrol_new and soc_dai_link.

Both are used within this header so need to be declared.

---
 include/sound/soc-topology.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
include/sound/soc-topology.h +2 -0
index f9cc7b9271ac..7ea2794e1c6a 100644
@@ -28,6 +28,8 @@ struct snd_soc_component;
 struct snd_soc_tplg_pcm_fe;
 struct snd_soc_dapm_context;
 struct snd_soc_card;
+struct snd_kcontrol_new;
+struct snd_soc_dai_link;
 
 /* object scan be loaded and unloaded in groups with identfying indexes */
 #define SND_SOC_TPLG_INDEX_ALL	0	/* ID that matches all FW objects */
Signature · 1 line
2.11.0
maintainer
#1 lore raw

Applied "ASoC: topology: Fix potential build issues with undeclared structs" to the asoc tree

The patch

ASoC: topology: Fix potential build issues with undeclared structs

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 294de6e372673229432dc8bcd80964223bc1589d Mon Sep 17 00:00:00 2001

From: Liam Girdwood <[email protected]>
Date: Tue, 6 Jun 2017 15:55:04 +0100
Subject: [PATCH] ASoC: topology: Fix potential build issues with undeclared
structs

We should be declaring snd_kcontrol_new and soc_dai_link as both are used within this header so need to be declared.

[Reworded commit message to indicate this wasn't an immediate build failure -- broonie]

---
 include/sound/soc-topology.h | 2 ++
 1 file changed, 2 insertions(+)
include/sound/soc-topology.h +2 -0
index f9cc7b9271ac..b8da221615e0 100644
@@ -28,6 +28,8 @@ struct snd_soc_component;
 struct snd_soc_tplg_pcm_fe;
 struct snd_soc_dapm_context;
 struct snd_soc_card;
+struct snd_kcontrol_new;
+struct snd_soc_dai_link;
 
 /* object scan be loaded and unloaded in groups with identfying indexes */
 #define SND_SOC_TPLG_INDEX_ALL	0	/* ID that matches all FW objects */
Signature · 1 line
2.11.0