drm/i915: Remove unecessary PORT3 definition.
Subsystems (2)
Rodrigo Vivi
maintainerPATCH 1/1 drm/i915: Remove unecessary PORT3 definition.
Let's be picky and just use PICK directly. So we can extend this later without creating a new PORT_X por every new number of ports we have to handle.
--- drivers/gpu/drm/i915/i915_reg.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +2 -4
@@ -58,10 +58,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define _MMIO_TRANS (tran, a, b) _MMIO(_TRANS(tran, a, b))#define _PORT (port, a, b) ((a) + (port)*((b)-(a)))#define _MMIO_PORT (port, a, b) _MMIO(_PORT(port, a, b)) -#define _PIPE3 (pipe, ...) _PICK(pipe, __VA_ARGS__) -#define _MMIO_PIPE3 (pipe, a, b, c) _MMIO(_PIPE3(pipe, a, b, c)) -#define _PORT3 (port, ...) _PICK(port, __VA_ARGS__) -#define _MMIO_PORT3 (pipe, a, b, c) _MMIO(_PORT3(pipe, a, b, c)) +#define _MMIO_PIPE3 (pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c)) +#define _MMIO_PORT3 (pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))#define _PHY3 (phy, ...) _PICK(phy, __VA_ARGS__)#define _MMIO_PHY3 (phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Just a very tiny nitpick about correction in the
spelling of "unnecessary" in the title.
Other than that
Quoted 31 lines · Rodrigo Vivi
Let's be picky and just use PICK directly. So we can extend this later without creating a new
PORT_Xpor every new number of ports we have to handle.Cc Manasi Navare <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/i915_reg.h +2
-4@@ -58,10 +58,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define _MMIO_TRANS (tran, a, b) _MMIO(_TRANS(tran, a, b))#define _PORT (port, a, b) ((a) + (port)*((b)-(a)))#define _MMIO_PORT (port, a, b) _MMIO(_PORT(port, a, b)) -#define _PIPE3 (pipe, ...) _PICK(pipe, __VA_ARGS__) -#define _MMIO_PIPE3 (pipe, a, b, c) _MMIO(_PIPE3(pipe, a, b, c)) -#define _PORT3 (port, ...) _PICK(port, __VA_ARGS__) -#define _MMIO_PORT3 (pipe, a, b, c) _MMIO(_PORT3(pipe, a, b, c)) +#define _MMIO_PIPE3 (pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c)) +#define _MMIO_PORT3 (pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))#define _PHY3 (phy, ...) _PICK(phy, __VA_ARGS__)#define _MMIO_PHY3 (phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
patch merged to dinq with the fixed spelling.
Thanks for the review
Quoted 43 lines · Manasi Navare
Just a very tiny nitpick about correction in the
spelling of "unnecessary" in the title.Other than that
Reviewed-by Manasi Navare <[email protected]>Quoted 29 lines · Rodrigo Vivi
Let's be picky and just use PICK directly. So we can extend this later without creating a new
PORT_Xpor every new number of ports we have to handle.Cc Manasi Navare <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/i915_reg.h +2
-5@@ -58,10 +58,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define _MMIO_TRANS (tran, a, b) _MMIO(_TRANS(tran, a, b))#define _PORT (port, a, b) ((a) + (port)*((b)-(a)))#define _MMIO_PORT (port, a, b) _MMIO(_PORT(port, a, b)) -#define _PIPE3 (pipe, ...) _PICK(pipe, __VA_ARGS__) -#define _MMIO_PIPE3 (pipe, a, b, c) _MMIO(_PIPE3(pipe, a, b, c)) -#define _PORT3 (port, ...) _PICK(port, __VA_ARGS__) -#define _MMIO_PORT3 (pipe, a, b, c) _MMIO(_PORT3(pipe, a, b, c)) +#define _MMIO_PIPE3 (pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c)) +#define _MMIO_PORT3 (pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))#define _PHY3 (phy, ...) _PICK(phy, __VA_ARGS__)#define _MMIO_PHY3 (phy, a, b, c) _MMIO(_PHY3(phy, a, b, c)) --Quoted 2 lines
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Remove unecessary PORT3 definition. (rev2)
In reply to Rodrigo Vivi== Series Details ==
== Series Details ==
Series: drm/i915: Remove unecessary PORT3 definition. (rev2)
URL : https://patchwork.freedesktop.org/series/25313/
State : success
== Summary ==
Series 25313v2 drm/i915: Remove unecessary PORT3 definition.
https://patchwork.freedesktop.org/api/1.0/series/25313/revisions/2/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
fail -> PASS (fi-snb-2600) fdo#100007
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-skl-6700hq) fdo#100461fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100461 https://bugs.freedesktop.org/show_bug.cgi?id=100461
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:445s fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:441s fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:575s fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:519s fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:491s fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:480s fi-glk-2a total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:587s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:433s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:412s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:418s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:494s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:466s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:474s fi-kbl-7560u total:278 pass:267 dwarn:1 dfail:0 fail:0 skip:10 time:571s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:464s fi-skl-6700hq total:278 pass:229 dwarn:1 dfail:0 fail:26 skip:22 time:422s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:464s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:499s fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:434s fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:536s fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time:404s
9458d5928c9c2731fe32329ba2219d642b1f81f2 drm-tip: 2017y-06m-06d-16h-35m-12s UTC integration manifest 6cb69f3 drm/i915: Remove unecessary PORT3 definition.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4891/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx