Skip to contentSkip to conversation

drm/amdgpu:ucode bo init add contiguous flag

PATCH In review horchen 1 participant 2 messages Jun 9, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

horchen

author
#0 lore raw

PATCH 1/1 drm/amdgpu:ucode bo init add contiguous flag

Under VF environment, the ucode would be settled to the visible VRAM, As it would be pinned to the visible VRAM, it's better to add contiguous flag,otherwise it need to move gpu address during the pin process. This movement is not necessary.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
 mode change 100644 => 100755 drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c +2 -1
old mode 100644
new mode 100755
index f2c6c6d..563ceb7
@@ -348,7 +348,8 @@ int amdgpu_ucode_init_bo(struct amdgpu_device *adev)
 	if (!amdgpu_sriov_vf(adev) || !adev->in_reset ) {
 		err = amdgpu_bo_create(adev, adev->firmware.fw_size, PAGE_SIZE, true,
 					amdgpu_sriov_vf(adev) ? AMDGPU_GEM_DOMAIN_VRAM : AMDGPU_GEM_DOMAIN_GTT,
-					0, NULL, NULL, bo);
+					amdgpu_sriov_vf(adev) ? AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS : 0,
+					NULL, NULL, bo);
 		if (err) {
 			dev_err(adev->dev, "(%d) Firmware buffer allocate failed\n", err);
 			goto failed;
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1496999922-6454-1-git-send-email-horace.chen-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Sorry, branch wrong, please ignore this.

Regards,
Horace.

-----Original Message-----
From: horchen [mailto:[email protected]]
Sent: Friday, June 09, 2017 5:19 PM
To: [email protected]
Cc: Huang, Ray; Chen, Horace
Subject: [PATCH] drm/amdgpu:ucode bo init add contiguous flag

Under VF environment, the ucode would be settled to the visible VRAM, As it would be pinned to the visible VRAM, it's better to add contiguous flag,otherwise it need to move gpu address during the pin process. This movement is not necessary.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)  mode change 100644 => 100755 drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c +2 -1
old mode 100644
new mode 100755
index f2c6c6d..563ceb7
@@ -348,7 +348,8 @@ int amdgpu_ucode_init_bo(struct amdgpu_device *adev)
 	if (!amdgpu_sriov_vf(adev) || !adev->in_reset ) {
 		err = amdgpu_bo_create(adev, adev->firmware.fw_size, PAGE_SIZE, true,
 					amdgpu_sriov_vf(adev) ? AMDGPU_GEM_DOMAIN_VRAM : AMDGPU_GEM_DOMAIN_GTT,
-					0, NULL, NULL, bo);
+					amdgpu_sriov_vf(adev) ? AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS : 0,
+					NULL, NULL, bo);
 		if (err) {
 			dev_err(adev->dev, "(%d) Firmware buffer allocate failed\n", err);
 			goto failed;

--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx