Skip to contentSkip to conversation

Patch "serial: ifx6x60: fix use-after-free on module unload" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jun 9, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

serial: ifx6x60: fix use-after-free on module unload

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
serial-ifx6x60-fix-use-after-free-on-module-unload.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 1e948479b3d63e3ac0ecca13cbf4921c7d17c168 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Wed, 26 Apr 2017 12:24:21 +0200
Subject: serial: ifx6x60: fix use-after-free on module unload

From: Johan Hovold <[email protected]>

commit 1e948479b3d63e3ac0ecca13cbf4921c7d17c168 upstream.

Make sure to deregister the SPI driver before releasing the tty driver to avoid use-after-free in the SPI remove callback where the tty devices are deregistered.

Fixes 72d4724ea54c ("serial: ifx6x60: Add modem power off function in the platform reboot process")
Cc Jun Chen <[email protected]>
---
 drivers/tty/serial/ifx6x60.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/ifx6x60.c +1 -1
@@ -1382,9 +1382,9 @@ static struct spi_driver ifx_spi_driver
 static void __exit ifx_spi_exit(void)
 {
 	/* unregister */
+	spi_unregister_driver(&ifx_spi_driver);
 	tty_unregister_driver(tty_drv);
 	put_tty_driver(tty_drv);
-	spi_unregister_driver(&ifx_spi_driver);
 	unregister_reboot_notifier(&ifx_modem_reboot_notifier_block);
 }
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/serial-ifx6x60-fix-use-after-free-on-module-unload.patch