Skip to contentSkip to conversation

intel-ci: Add comments on test order to fast-feedback.testlist

PATCH In review Petri Latvala 2 participants 5 messages Jun 9, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 intel-ci: Add comments on test order to fast-feedback.testlist

Document the test ordering choices in fast-feedback.testlist.

For comments in testlists, piglit commit

commit 0c535186d624071098c10003fdafe8f475ed9ae7
Author: Petri Latvala <[email protected]>
Date: Wed Feb 1 12:57:45 2017 +0200

framework/programs/run.py: Allow comments in test-list files.

is required.

---
 tests/intel-ci/fast-feedback.testlist | 7 +++++++
 1 file changed, 7 insertions(+)
tests/intel-ci/fast-feedback.testlist +7 -0
index 5ffa2ce..ce7a41f 100644
@@ -1,3 +1,5 @@
+# Keep alphabetically sorted by default
+
 igt@core_auth@basic-auth
 igt@core_prop_blob@basic
 igt@drv_getparams_basic@basic-eu-total
@@ -270,6 +272,11 @@ igt@vgem_basic@dmabuf-mmap
 igt@vgem_basic@mmap
 igt@vgem_basic@second-client
 igt@vgem_basic@sysfs
+
+# All tests that do module unloading and reloading are executed last.
+# They will sometimes reveal issues of earlier tests leaving the
+# driver in a broken state that is not otherwise noticed in that test.
+
 igt@vgem_basic@unload
 igt@drv_module_reload@basic-reload
 igt@drv_module_reload@basic-no-display
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 2/4 tests/Makefile.am: Only ignore generated gitignore in gitignore

When generating the .gitignore file, use /.gitignore instead of .gitignore to not have it apply to subdirectories.

---
 tests/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/Makefile.am +1 -1
index 9a1c770..873850d 100644
@@ -52,7 +52,7 @@ dist_pkgdata_DATA = \
 
 all-local: .gitignore
 .gitignore: Makefile.sources
-	@echo "$(pkglibexec_PROGRAMS) $(HANG) test-list.txt test-list-full.txt .gitignore" | sed 's/\s\+/\n/g' | sort > $@
+	@echo "$(pkglibexec_PROGRAMS) $(HANG) test-list.txt test-list-full.txt /.gitignore" | sed 's/\s\+/\n/g' | sort > $@
 
 pkgdata_DATA = test-list.txt test-list-full.txt
 
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

PATCH 3/4 intel-ci: Have the directory included in the distributed tarballs

In reply to Petri Latvala
---
 configure.ac               | 1 +
 tests/Makefile.am          | 2 ++
 tests/intel-ci/Makefile.am | 7 +++++++
 3 files changed, 10 insertions(+)
 create mode 100644 tests/intel-ci/Makefile.am
configure.ac +1 -0
index 5f80b08..fa0593b 100644
@@ -360,6 +360,7 @@ AC_CONFIG_FILES([
 		 man/Makefile
 		 scripts/Makefile
 		 tests/Makefile
+		 tests/intel-ci/Makefile
 		 tools/Makefile
 		 tools/null_state_gen/Makefile
 		 tools/registers/Makefile
tests/Makefile.am +2 -0
index 873850d..b051364 100644
@@ -1,5 +1,7 @@
 include Makefile.sources
 
+SUBDIRS = intel-ci
+
 if HAVE_LIBDRM_AMDGPU
     TESTS_progs += $(AMDGPU_TESTS)
 endif
tests/intel-ci/Makefile.am new file +7 -0
new file mode 100644
index 0000000..9fb9744
@@ -0,0 +1,7 @@
+EXTRA_DIST = \
+	extended.testlist \
+	fast-feedback.testlist \
+	generic.testlist \
+	meta.testlist \
+	README \
+	$(NULL)
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

PATCH 4/4 intel-ci: Document the public CI results web page

In reply to Petri Latvala
---
 tests/intel-ci/README | 3 +++
 1 file changed, 3 insertions(+)
tests/intel-ci/README +3 -0
index ae92460..d17922e 100644
@@ -24,6 +24,9 @@ fast-feedback.testlist
 Fast-feedback is the testlist that is run for Patchwork and Trybot
 testing. It is also run on various drm-intel-* branches.
 
+The results of CI runs on drm-tip can be found in
+https://intel-gfx-ci.01.org/CI/
+
 Time limit: Full run must complete in 15 minutes on all tested
 platforms.
 
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/4
#4 lore raw
In reply to Petri Latvala
Quoted 8 lines · Petri Latvala

Document the test ordering choices in fast-feedback.testlist.

For comments in testlists, piglit commit

commit 0c535186d624071098c10003fdafe8f475ed9ae7
Author: Petri Latvala <[email protected]>
Date: Wed Feb 1 12:57:45 2017 +0200

Quoted 5 lines

framework/programs/run.py: Allow comments in test-list files.

is required.

The whole series:

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx