Skip to contentSkip to conversation

Patch "crypto: asymmetric_keys - handle EBUSY due to backlog correctly" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jun 12, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

crypto: asymmetric_keys - handle EBUSY due to backlog correctly

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
crypto-asymmetric_keys-handle-ebusy-due-to-backlog-correctly.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From e68368aed56324e2e38d4f6b044bb8cf82077fc2 Mon Sep 17 00:00:00 2001

From: Gilad Ben-Yossef <[email protected]>
Date: Thu, 18 May 2017 16:29:23 +0300
Subject: crypto: asymmetric_keys - handle EBUSY due to backlog correctly

From: Gilad Ben-Yossef <[email protected]>

commit e68368aed56324e2e38d4f6b044bb8cf82077fc2 upstream.

public_key_verify_signature() was passing the CRYPTO_TFM_REQ_MAY_BACKLOG flag to akcipher_request_set_callback() but was not handling correctly the case where a -EBUSY error could be returned from the call to crypto_akcipher_verify() if backlog was used, possibly casuing data corruption due to use-after-free of buffers.

Resolve this by handling -EBUSY correctly.

---
 crypto/asymmetric_keys/public_key.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
crypto/asymmetric_keys/public_key.c +1 -1
@@ -141,7 +141,7 @@ int public_key_verify_signature(const st
 	 * signature and returns that to us.
 	 */
 	ret = crypto_akcipher_verify(req);
-	if (ret == -EINPROGRESS) {
+	if ((ret == -EINPROGRESS) || (ret == -EBUSY)) {
 		wait_for_completion(&compl.completion);
 		ret = compl.err;
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/crypto-drbg-wait-for-crypto-op-not-signal-safe.patch queue-4.11/crypto-gcm-wait-for-crypto-op-not-signal-safe.patch queue-4.11/crypto-asymmetric_keys-handle-ebusy-due-to-backlog-correctly.patch