Skip to contentSkip to conversation

Patch "ovl: fix creds leak in copy up error path" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jun 12, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ovl: fix creds leak in copy up error path

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ovl-fix-creds-leak-in-copy-up-error-path.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 8137ae26d25303e7b5cfb418fd28b976461e5b6e Mon Sep 17 00:00:00 2001

From: Amir Goldstein <[email protected]>
Date: Tue, 16 May 2017 08:45:46 +0300
Subject: ovl: fix creds leak in copy up error path

From: Amir Goldstein <[email protected]>

commit 8137ae26d25303e7b5cfb418fd28b976461e5b6e upstream.

Fixes 42f269b92540 ("ovl: rearrange code in ovl_copy_up_locked()")
---
 fs/overlayfs/copy_up.c |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
fs/overlayfs/copy_up.c +6 -5
@@ -269,12 +269,13 @@ static int ovl_copy_up_locked(struct den
 		temp = ovl_do_tmpfile(upperdir, stat->mode);
 	else
 		temp = ovl_lookup_temp(workdir, dentry);
-	err = PTR_ERR(temp);
-	if (IS_ERR(temp))
-		goto out1;
-
 	err = 0;
-	if (!tmpfile)
+	if (IS_ERR(temp)) {
+		err = PTR_ERR(temp);
+		temp = NULL;
+	}
+
+	if (!err && !tmpfile)
 		err = ovl_create_real(wdir, temp, &cattr, NULL, true);
 
 	if (new_creds) {

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/ovl-fix-creds-leak-in-copy-up-error-path.patch