Skip to contentSkip to conversation

Patch "cpufreq: cpufreq_register_driver() should return -ENODEV if init fails" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jun 12, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

cpufreq: cpufreq_register_driver() should return -ENODEV if init fails

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
cpufreq-cpufreq_register_driver-should-return-enodev-if-init-fails.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 6c77003677d5f1ce15f26d24360cb66c0bc07bb3 Mon Sep 17 00:00:00 2001

From: David Arcari <[email protected]>
Date: Fri, 26 May 2017 11:37:31 -0400
Subject: cpufreq: cpufreq_register_driver() should return -ENODEV if init fails

From: David Arcari <[email protected]>

commit 6c77003677d5f1ce15f26d24360cb66c0bc07bb3 upstream.

For a driver that does not set the CPUFREQ_STICKY flag, if all of the ->init() calls fail, cpufreq_register_driver() should return an error. This will prevent the driver from loading.

Fixes ce1bcfe94db8 (cpufreq: check cpufreq_policy_list instead of scanning policies for all CPUs)
---
 drivers/cpufreq/cpufreq.c |    1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/cpufreq.c +1 -0
@@ -2468,6 +2468,7 @@ int cpufreq_register_driver(struct cpufr
 	if (!(cpufreq_driver->flags & CPUFREQ_STICKY) &&
 	    list_empty(&cpufreq_policy_list)) {
 		/* if all ->init() calls failed, unregister */
+		ret = -ENODEV;
 		pr_debug("%s: No CPU initialized for driver %s\n", __func__,
 			 driver_data->name);
 		goto err_if_unreg;

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/cpufreq-cpufreq_register_driver-should-return-enodev-if-init-fails.patch