Patch "[media] rc-core: race condition during ir_raw_event_register()" has been added to the 4.11-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
[media] rc-core: race condition during ir_raw_event_register()
to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
rc-core-race-condition-during-ir_raw_event_register.patch
and it can be found in the queue-4.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
963761a0b2e85663ee4a5630f72930885a06598aMon Sep 17 00:00:00 2001
From: Sean Young <[email protected]>
Date: Wed, 24 May 2017 06:24:51 -0300
Subject: [media] rc-core: race condition during ir_raw_event_register()
From: Sean Young <[email protected]>
commit 963761a0b2e85663ee4a5630f72930885a06598a upstream.
A rc device can call ir_raw_event_handle() after rc_allocate_device(), but before rc_register_device() has completed. This is racey because rcdev->raw is set before rcdev->raw->thread has a valid value.
--- drivers/media/rc/rc-ir-raw.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)
drivers/media/rc/rc-ir-raw.c +8 -5
@@ -211,7 +211,7 @@ EXPORT_SYMBOL_GPL(ir_raw_event_set_idle)*/ void ir_raw_event_handle (struct rc_dev *dev) { -if (!dev->raw) +if (!dev->raw || !dev->raw->thread)return ;wake_up_process (dev->raw->thread);
@@ -490,6 +490,7 @@ int ir_raw_event_register(struct rc_dev {int rc;struct ir_raw_handler *handler; +struct task_struct *thread;if (!dev)return -EINVAL ;
@@ -507,13 +508,15 @@ int ir_raw_event_register(struct rc_dev* because the event is coming from userspace */ if (dev->driver_type !=RC_DRIVER_IR_RAW_TX ) { - dev->raw->thread =kthread_run (ir_raw_event_thread, dev->raw, -"rc%u" , dev->minor); + thread =kthread_run (ir_raw_event_thread, dev->raw,"rc%u" , + dev->minor); -if (IS_ERR (dev->raw->thread)) { - rc =PTR_ERR (dev->raw->thread); +if (IS_ERR (thread)) { + rc =PTR_ERR (thread); goto out; } + + dev->raw->thread = thread; }mutex_lock (&ir_raw_handler_lock);
Patches currently in stable-queue which might be from [email protected] are
queue-4.11/rc-core-race-condition-during-ir_raw_event_register.patch