Skip to contentSkip to conversation

Patch "cgroup: mark cgroup_get() with __maybe_unused" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jun 12, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

cgroup: mark cgroup_get() with __maybe_unused

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
cgroup-mark-cgroup_get-with-__maybe_unused.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 310b4816a5d8082416b4ab83e5a7b3cb92883a4d Mon Sep 17 00:00:00 2001

From: Tejun Heo <[email protected]>
Date: Mon, 1 May 2017 15:24:14 -0400
Subject: cgroup: mark cgroup_get() with __maybe_unused

From: Tejun Heo <[email protected]>

commit 310b4816a5d8082416b4ab83e5a7b3cb92883a4d upstream.

a590b90d472f ("cgroup: fix spurious warnings on cgroup_is_dead() from cgroup_sk_alloc()") converted most cgroup_get() usages to cgroup_get_live() leaving cgroup_sk_alloc() the sole user of cgroup_get(). When !CONFIG_SOCK_CGROUP_DATA, this ends up triggering unused warning for cgroup_get().

Silence the warning by adding __maybe_unused to cgroup_get().

---
 kernel/cgroup/cgroup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/cgroup/cgroup.c +1 -1
@@ -436,7 +436,7 @@ out_unlock:
 	return css;
 }
 
-static void cgroup_get(struct cgroup *cgrp)
+static void __maybe_unused cgroup_get(struct cgroup *cgrp)
 {
 	css_get(&cgrp->self);
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/cgroup-mark-cgroup_get-with-__maybe_unused.patch queue-4.11/cpuset-consider-dying-css-as-offline.patch queue-4.11/revert-ata-sata_mv-convert-to-devm_ioremap_resource.patch queue-4.11/block-avoid-that-blk_exit_rl-triggers-a-use-after-free.patch queue-4.11/cgroup-prevent-kill_css-from-being-called-more-than-once.patch queue-4.11/ahci-acer-sa5-271-ssd-not-detected-fix.patch