Patch "netfilter: nf_conntrack_sip: fix wrong memory initialisation" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
netfilter: nf_conntrack_sip: fix wrong memory initialisation
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
netfilter-nf_conntrack_sip-fix-wrong-memory-initialisation.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
da2f27e9e615d1c799c9582b15262458da61fddcMon Sep 17 00:00:00 2001
From: Christophe Leroy <[email protected]>
Date: Wed, 1 Mar 2017 15:33:26 +0100
Subject: netfilter: nf_conntrack_sip: fix wrong memory initialisation
From: Christophe Leroy <[email protected]>
commit da2f27e9e615d1c799c9582b15262458da61fddc upstream.
In commit 82de0be6862cd ("netfilter: Add helper array register/unregister functions"),
struct nf_conntrack_helper sip[MAX_PORTS][4] was changed to sip[MAX_PORTS * 4], so the memory init should have been changed to memset(&sip[4 * i], 0, 4 * sizeof(sip[i]));
But as the sip[] table is allocated in the BSS, it is already set to 0
--- net/netfilter/nf_conntrack_sip.c | 2 -- 1 file changed, 2 deletions(-)
net/netfilter/nf_conntrack_sip.c +0 -2
@@ -1630,8 +1630,6 @@ static int __init nf_conntrack_sip_init( ports[ports_c++] =SIP_PORT ;for (i =0 ; i < ports_c; i++) { -memset (&sip[i],0 ,sizeof (sip[i])); - nf_ct_helper_init(&sip[4 * i], AF_INET, IPPROTO_UDP, "sip", SIP_PORT, ports[i], i, sip_exp_policy, SIP_EXPECT_MAX,
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/netfilter-nf_conntrack_sip-fix-wrong-memory-initialisation.patch