Skip to contentSkip to conversation

Patch "ibmvnic: Call napi_disable instead of napi_enable in failure path" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jun 15, 2017

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ibmvnic: Call napi_disable instead of napi_enable in failure path

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ibmvnic-call-napi_disable-instead-of-napi_enable-in-failure-path.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Jun 15 11:12:23 CEST 2017

From: Nathan Fontenot <[email protected]>
Date: Tue, 23 May 2017 21:53:38 -0400
Subject: ibmvnic: Call napi_disable instead of napi_enable in failure path

From: Nathan Fontenot <[email protected]>

[ Upstream commit e722af6391949e8851310441bb0cec157d25611d ]

The failure path in ibmvnic_open() mistakenly makes a second call to napi_enable instead of calling napi_disable. This can result in a BUG_ON for any queues that were enabled in the previous call to napi_enable.

---
 drivers/net/ethernet/ibm/ibmvnic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/ibm/ibmvnic.c +1 -1
@@ -505,7 +505,7 @@ rx_pool_alloc_failed:
 	adapter->rx_pool = NULL;
 rx_pool_arr_alloc_failed:
 	for (i = 0; i < adapter->req_rx_queues; i++)
-		napi_enable(&adapter->napi[i]);
+		napi_disable(&adapter->napi[i]);
 alloc_napi_failed:
 	return -ENOMEM;
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/ibmvnic-call-napi_disable-instead-of-napi_enable-in-failure-path.patch queue-4.9/ibmvnic-initialize-completion-variables-before-starting-work.patch